[WIP] Migrate Gallery benchmarks out of flutter/flutter (flutter side)
#66351
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter/flutter.flutter/flutter (flutter side)
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
| web_benchmarks: | ||
| git: | ||
| url: https://github.com/pennzht/web_benchmarks.git | ||
| ref: 40a483181861e6cd84dd14a6d31cb45a966f8d59 |
There was a problem hiding this comment.
In order to fix the issue in question this will become a normal pub dependency, correct?
There was a problem hiding this comment.
Yes, this will become something like web_benchmarks: <version> similar to animations: 1.1.2 below, once the pub package is published.
| return galleryBenchmarkResult; | ||
| } | ||
|
|
||
| // Both succeeded. Combine data. |
There was a problem hiding this comment.
What do you think of making this a method on the TaskResult class? Something like this:
class TaskResult {
TaskResult combine(TaskResult other) {
...
}
}The combine method could internally decide whether the overall result is a success or not, and it could validate that there's no overlap in data (e.g. that the benchmark score keys are unique).
|
This pull request is not suitable for automatic merging in its current state.
|
|
Are there still plans for this or should we close it? |
|
Since there has been no progress here for a few weeks and the PR is marked "draft", I'm going to close the PR for now. Please do not hesitate to create a new PR when this is ready to land! Thanks! |
Working in progress. Do not review yet.
Description
This PR moves Gallery web benchmarks out of Flutter proper and separates the dependencies for
flutter/flutterandflutter/gallery, allowing the two repos to freely update dependencies in the future, while preserving the important benchmarks which give us tons of useful signals, not just performance, but stability also.These three PRs (see References section below) behave in the following way:
web_benchmarkspackage, the common package used by both non-Gallery web benchmarks and Gallery web benchmarks.flutter/gallery.flutter/flutterto stop usingpubspec.yamldependencies, and start pullingflutter/galleryat runtime.The three PRs must be landed in this order.
Currently, some dependencies / git references are pointing to my own branches. They will be moved to official branches once the corresponding prerequisites are landed.
References
web_benchmarks side — pennzht/web_benchmarks#1
gallery side — flutter/gallery#321
flutter side — #66351
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
No tests are added here.
Tests are added for the
web_benchmarkspackage.Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.