This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Required weight is returned in case it exceeds limit. #2952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
commented
Apr 28, 2021
| @@ -578,7 +578,7 @@ impl MultiLocation { | |||
| let self_parents = self.parent_count(); | |||
| let prefix_rest = prefix.len() - prefix.parent_count(); | |||
| let skipped = self_parents.min(prefix_rest); | |||
| if self.len() + prefix.len() - 2 * skipped > 4 { | |||
| if self.len() + prefix.len() - 2 * skipped > 8 { | |||
There was a problem hiding this comment.
Minor fix since we now have 8 items in MultiLocation, not 4.
There was a problem hiding this comment.
We will always need to remember to bump this number?
shawntabrizi
approved these changes
Apr 28, 2021
pepyakin
approved these changes
Apr 28, 2021
ordian
pushed a commit
that referenced
this pull request
May 3, 2021
* master: (98 commits) Companion PR for #8414 - Remove OffencesWeightSoftLimit (#2966) Companion for Substrate#8663 (#2945) Add parachains modules to Westend and Kusama runtimes (#2854) Make KeyStore optional (#2964) v0.9.0 prep (#2959) Implement null weight trader (#2957) feat: add proc macro to reduce overseer mock boilerplate (#2949) Allow normal accounts to execute XCM for withdraw+teleport (#2953) Required weight is returned in case it exceeds limit. (#2952) Bump version, bump substrate & update benchmarks in preparation for v0.8.31 (#2938) Bump BEEFY (#2946) Send statements to own backing group first (#2927) Bump (#2942) Add Dev Config for Rococo and Wococo (#2928) change junction parachain id from named field to unnamed field (#2940) fix link (#2941) Add XCM Origin and converter (#2896) Add Statemint teleport (#2934) CI: build colander on rococo branch too (#2936) Bump BEEFY (#2937) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.