This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add proc macro to reduce overseer mock boilerplate #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
reviewed
Apr 28, 2021
node/overseer/subsystems-gen/tests/ui/err-01-generic-used-twice.rs
Outdated
Show resolved
Hide resolved
f5f7d69
to
b105b92
Compare
ordian
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo small nits.
ordian
pushed a commit
that referenced
this pull request
May 3, 2021
* master: (98 commits) Companion PR for #8414 - Remove OffencesWeightSoftLimit (#2966) Companion for Substrate#8663 (#2945) Add parachains modules to Westend and Kusama runtimes (#2854) Make KeyStore optional (#2964) v0.9.0 prep (#2959) Implement null weight trader (#2957) feat: add proc macro to reduce overseer mock boilerplate (#2949) Allow normal accounts to execute XCM for withdraw+teleport (#2953) Required weight is returned in case it exceeds limit. (#2952) Bump version, bump substrate & update benchmarks in preparation for v0.8.31 (#2938) Bump BEEFY (#2946) Send statements to own backing group first (#2927) Bump (#2942) Add Dev Config for Rococo and Wococo (#2928) change junction parachain id from named field to unnamed field (#2940) fix link (#2941) Add XCM Origin and converter (#2896) Add Statemint teleport (#2934) CI: build colander on rococo branch too (#2936) Bump BEEFY (#2937) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY: Remove some boiler plate code around
AllSubsystems
helper generic in exchange for a small proc macro.