Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Apr 28, 2021

DRY: Remove some boiler plate code around AllSubsystems helper generic in exchange for a small proc macro.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 28, 2021
@drahnr drahnr self-assigned this Apr 28, 2021
@drahnr drahnr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 28, 2021
@drahnr drahnr changed the title feat: add proc macro to reduce boilerplate feat: add proc macro to reduce overseer mock abstraction boilerplate Apr 28, 2021
@drahnr drahnr changed the title feat: add proc macro to reduce overseer mock abstraction boilerplate feat: add proc macro to reduce overseer mock boilerplate Apr 28, 2021
@drahnr drahnr force-pushed the bernhard-chore-proc-macro branch from f5f7d69 to b105b92 Compare April 28, 2021 15:29
Copy link

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo small nits.

@drahnr drahnr merged commit ed71f32 into master Apr 29, 2021
@drahnr drahnr deleted the bernhard-chore-proc-macro branch April 29, 2021 10:07
ordian pushed a commit that referenced this pull request May 3, 2021
* master: (98 commits)
  Companion PR for #8414 - Remove OffencesWeightSoftLimit (#2966)
  Companion for Substrate#8663 (#2945)
  Add parachains modules to Westend and Kusama runtimes (#2854)
  Make KeyStore optional (#2964)
  v0.9.0 prep (#2959)
  Implement null weight trader (#2957)
  feat: add proc macro to reduce overseer mock boilerplate (#2949)
  Allow normal accounts to execute XCM for withdraw+teleport (#2953)
  Required weight is returned in case it exceeds limit. (#2952)
  Bump version, bump substrate & update benchmarks in preparation for v0.8.31 (#2938)
  Bump BEEFY (#2946)
  Send statements to own backing group first (#2927)
  Bump (#2942)
  Add Dev Config for Rococo and Wococo (#2928)
  change junction parachain id from named field to unnamed field (#2940)
  fix link (#2941)
  Add XCM Origin and converter (#2896)
  Add Statemint teleport (#2934)
  CI: build colander on rococo branch too (#2936)
  Bump BEEFY (#2937)
  ...
@drahnr drahnr mentioned this pull request Jun 12, 2021
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants