Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Implementer's Guide: Router fixes #1727

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Implementer's Guide: Router fixes #1727

merged 2 commits into from
Sep 16, 2020

Conversation

pepyakin
Copy link
Contributor

This PR bundles two commits which were originally introduced in #1679

First commit reindents the router module with 4 spaces. The guide used to use 2 spaces for indentation. The problem with that is mdbook doesn't recognize them as a proper indentation and thus doesn't render indent properly.

The second aggregates multiple fixes that were introduced while working on #1678

@pepyakin
Guide: Reindent the router module with 4 spaces
ab80d73 
The guide used to use 2 spaces for indentation. The problem with that is `mdbook` doesn't recognize them as a proper indentation and thus doesn't render indent properly.

A couple of things are not indented here because they will be changed in the following commits
@pepyakin
Guide: a bunch of fixes
753c3d9
@pepyakin pepyakin added I7-documentation Documentation needs fixing, improving or augmenting. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 16, 2020
@pepyakin pepyakin added this to the Grosvenor milestone Sep 16, 2020
@ordian ordian merged commit 4afe311 into master Sep 16, 2020
@ordian ordian deleted the ser-impl-guide-fixes branch September 16, 2020 15:52
ordian pushed a commit that referenced this pull request Sep 17, 2020
Merge branch 'master' into ao-validator-discovery-api
c03f766 
* master:
  Unbreak master (#1729)
  Skeleton of the Router module (#1726)
  Companion for #6825 (#1552)
  Update Polkadot tokenDecimals & tokenSymbol (#1711)
  Prepare Polkadot to be used by Cumulus (#1697)
  Companion for #7103 (WeightInfo for Vesting) (#1721)
  Implementer's Guide: Router fixes (#1727)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. I7-documentation Documentation needs fixing, improving or augmenting.
Projects
None yet
Milestone
Grosvenor
Development

Successfully merging this pull request may close these issues.
2 participants
@pepyakin @ordian