Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Skeleton of the Router module #1726

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Skeleton of the Router module #1726

merged 1 commit into from
Sep 17, 2020

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Sep 16, 2020 •
edited
Loading

Closes #1674

The purpose of this commit is to establish a foundation of the router module, it paves the way for the implementation of other features.

This commit is split from #1679

@pepyakin
Skeleton of the Router module
f4fc480 
The purpose of this commit is to establish a foundation of the router module, it paves the way for the implementation of other features.
@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 16, 2020
@pepyakin pepyakin added this to the Grosvenor milestone Sep 16, 2020
pepyakin
pepyakin commented Sep 16, 2020
View reviewed changes
runtime/parachains/src/router.rs

#[cfg(test)]
mod tests {
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by the following commits

@ordian ordian added A7-looksgoodtestsfail and removed A0-please_review Pull request needs code review. A7-looksgoodtestsfail labels Sep 16, 2020
@pepyakin
Copy link
Contributor Author

We believe that gitlab-check-runtime is a false-positive and is triggered because of the change in the paras_sudo_wrapper pallet.

Practically this pallet is not used anywhere except rococo. It seems that rococo is explictly not including into the check so bumping the version there won't help.

Thus, I am going to go ahead and merge this one

@pepyakin
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 17, 2020

Checks failed; merge aborted.

@pepyakin pepyakin merged commit f63d83f into master Sep 17, 2020
@pepyakin pepyakin deleted the ser-router-skeleton branch September 17, 2020 10:27
ordian pushed a commit that referenced this pull request Sep 17, 2020
Merge branch 'master' into ao-validator-discovery-api
c03f766 
* master:
  Unbreak master (#1729)
  Skeleton of the Router module (#1726)
  Companion for #6825 (#1552)
  Update Polkadot tokenDecimals & tokenSymbol (#1711)
  Prepare Polkadot to be used by Cumulus (#1697)
  Companion for #7103 (WeightInfo for Vesting) (#1721)
  Implementer's Guide: Router fixes (#1727)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
Grosvenor
Development

Successfully merging this pull request may close these issues.

Router module
2 participants
@pepyakin @ordian