fix: Enable TLS when using API Key for Temporal scaler #6707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
|
/run-e2e temporal |
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
|
I think this should be added to v2.17.1 as well |
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
|
/run-e2e temporal |
JorTurFer
approved these changes
Apr 26, 2025
mittalvaibhav1
pushed a commit
to mittalvaibhav1/keda
that referenced
this pull request
Apr 26, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
mittalvaibhav1
pushed a commit
to mittalvaibhav1/keda
that referenced
this pull request
Apr 26, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
mittalvaibhav1
pushed a commit
to mittalvaibhav1/keda
that referenced
this pull request
Apr 26, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
aliaqel-stripe
pushed a commit
to aliaqel-stripe/keda
that referenced
this pull request
May 9, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
aliaqel-stripe
pushed a commit
to aliaqel-stripe/keda
that referenced
this pull request
May 9, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
wozniakjan
pushed a commit
to wozniakjan/keda
that referenced
this pull request
May 15, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
wozniakjan
pushed a commit
to wozniakjan/keda
that referenced
this pull request
May 15, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan
added a commit
that referenced
this pull request
May 15, 2025
* fix: Admission Webhook blocks ScaledObject without metricType with fallback (#6702) * fix: Admission Webhook blocks ScaledObject without metricType with fallback Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Add unit test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Add e2e test Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Add more unit tests for scaledobject_types Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update changelog Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: AWS SQS Queue queueURLFromEnv not working (#6713) Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: Temporal scaler with API Key (#6707) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: add default Operation in Azure Service Bus scaler (#6731) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: ScalerCache gets the lock before operate the scalers (#6739) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: Use pinned version for nginx image (#6737) * fix: Use pinned version for nginx image Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix panic in gcp scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * Selenium Grid: Update metric name generated without part of empty (#6772) * Selenium Grid: Update metric name generated without part of empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG with the PR Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * chore: changelog and issue template v2.17.1 Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: rickbrouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Temporal scaler was failing with a "connection reset by peer" error when an API key was provided for authentication without explicitly configuring TLS.
This change modifies the getTemporalClient function to enforce a default TLS configuration when an API key is present in the trigger metadata. This aligns with the Temporal client's requirement for TLS when using API key authentication.
Also, a new test case has been added to TestParseTemporalMetadata to ensure the apiKey is correctly parsed.
Checklist
Fixes #6703