Skip to content

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented May 15, 2025

Releasing KEDA v2.17.1 patch with cherry-picked fixes from #6724

Checklist

see also: #6724

@wozniakjan wozniakjan requested a review from a team as a code owner May 15, 2025 09:20
rickbrouwer and others added 8 commits May 15, 2025 11:22
…llback (kedacore#6702)

* fix: Admission Webhook blocks ScaledObject without metricType with fallback

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* Add unit test

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

* Add e2e test

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* Add more unit tests for scaledobject_types

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

* Update changelog

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

* Update

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

---------

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
)

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
* fix: Use pinned version for nginx image

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* .

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix panic in gcp scaler

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

---------

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
…dacore#6772)

* Selenium Grid: Update metric name generated without part of empty

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Update CHANGELOG with the PR

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

---------

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan force-pushed the prepare_release_v2.17.1 branch from 1133060 to 98ed553 Compare May 15, 2025 09:23
@wozniakjan wozniakjan requested a review from Copilot May 15, 2025 09:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the v2.17.1 patch release by cherry-picking fixes from various issues and updating dependencies. Key changes include updated container image references across tests, new tests for fallback and SQS queue URL resolution, and code improvements in caching and TLS handling.

Reviewed Changes

Copilot reviewed 98 out of 98 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/internals/* Updated container image references for consistent dependency usage
tests/internals/fallback/fallback_test.go Added tests for scaled object without metric type and fallback behavior
pkg/scaling/cache/scalers_cache.go Improved locking by removing redundant RLock usage
pkg/scalers/temporal.go Added TLS configuration when API key is provided, but assignment may be overwritten
pkg/scalers/aws_sqs_queue_scaler.go Modified struct tag for QueueURL for environment variable resolution
apis/keda/v1alpha1/scaledobject_types.go Defaulting effective metric type when missing
CHANGELOG.md & .github/ISSUE_TEMPLATE/3_bug_report.yml Updated changelog and issue template options
Comments suppressed due to low confidence (1)

pkg/scalers/aws_sqs_queue_scaler.go:32

  • The updated struct tag for QueueURL removes the 'queueURLFromEnv' part, which may affect the environment variable resolution behavior. Please verify that this change is backward compatible and aligns with the intended design for resolving queue URL from the environment.
QueueURL                    string `keda:"name=queueURL, order=triggerMetadata;resolvedEnv"`

@wozniakjan
Copy link
Member Author

wozniakjan commented May 15, 2025

/run-e2e
Update: You can check the progress here

@wozniakjan wozniakjan merged commit a3e2090 into kedacore:release/v2.17 May 15, 2025
17 checks passed
@naikaayushnz
Copy link

will there be a helm chart release as well?

@joaopaulosr95 joaopaulosr95 mentioned this pull request May 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants