Push server docker images during the release (attempt 2) #19061

fgrzadkowski · 2015-12-23T14:42:57Z

This will release the following images:

gcr.io/google_containers/kube-apiserver-amd64            v1.2                581627bd855f        2 minutes ago        54.09 MB
gcr.io/google_containers/kube-controller-manager-amd64   v1.2                90ea7e237fd8        2 minutes ago        48.17 MB
gcr.io/google_containers/kube-proxy-amd64                v1.2                028858138a94        2 minutes ago        162.4 MB
gcr.io/google_containers/kube-scheduler-amd64            v1.2                75aae7f75086        2 minutes ago        33.5 MB
gcr.io/google_containers/hyperkube-amd64                 v1.2                b962b62aa778        3 minutes ago        297.1 MB

Fixes #11751

@ihmccreery @mikedanese @quinton-hoole

k8s-github-robot · 2015-12-23T14:52:11Z

Labelling this PR as size/M

k8s-bot · 2015-12-23T15:12:38Z

GCE e2e test build/test passed for commit 7cb6d74efff8ca3e27fdb47bd83c6381de26fa96.

k8s-bot · 2015-12-23T15:41:34Z

GCE e2e build/test failed for commit 3f939af292326db99f771bc39930a8f9d1b19ad6.

fgrzadkowski · 2015-12-23T15:49:59Z

Last failure is a flake in test:

Kubernetes e2e suite.Deployment deployment should scale up and down in the right order

luxas · 2015-12-25T21:48:34Z

build/common.sh

+  )
+
+  local platforms=(
+    "linux-amd64"


Shouldn't this be just amd64? Or am I missing something here?
Because I think the docker images should be named gcr.io/google_containers/binary-arch e.g. gcr.io/google_containers/hyperkube-amd64 instead of gcr.io/google_containers/hyperkube-linux-amd64

But, maybe you want darwin support in the future 😄

My initial motivation was consistency with how we name our server .tar.gz files with a release. However keeping only architecture has the advantage of being shorter.

@zmerlynn Any preference?

Another advantage with just the arch is consistency with hyperkube and some other images

What other images? I wouldn't take hyperkube as an example yet. It's still more like an experiment..

AFAIK @brendandburns has pushed the pause, skydns, exechealthz and other addon images as experimental images (with the arch naming)

The thing is just that we have to keep it consistent. I am working on first-class ARM support and the naming here is quite important.

I think we should go with arch only naming, because docker runs natively only on linux for the time being. If we want to support darwin or windows in the future is another (probably long) discussion

I agree that consistency is important. But as you can see it's not obvious with what we should be consistent :)

Indeed some images have been pushed with -arm suffix. I'll change the naming to just the arch.

BTW - I've noticed non-trivial ARM images cannot be build on amd64 machines. That means that we'll not be able to officially release those. How do you envision releasing ARM images?

@fgrzadkowski I'm working on it.
And yes, it's possible to dynamically cross-compile ARM binaries on amd64 hosts.
It's even possible to build ARM docker images on amd64, like hyperkube for example.
Inspiration: https://resin.io/blog/building-arm-containers-on-any-x86-machine-even-dockerhub/

I was so happy when I got this working: https://gist.github.com/luxas/e319b314f22b18243b1d
I have (locally) integrated this gist into kube-build and it worked even on ARMv6 (e.g. hyperkube as it is pushed now, only works on ARMv7)
So I'm gonna upload a PR with my work when it's ready.

Cool. Good to know.

I changed docker images naming to follow hyperkube convention.

mikedanese · 2015-12-28T17:15:01Z

Fyi, I want to include hack/lib in the release tar (see #19086). That would be a good place to share library code between build/ and cluster/ if you want to go with something more similar to the previous PR.

k8s-bot · 2015-12-29T11:40:47Z

GCE e2e test build/test passed for commit f46ed7ecc1827dc8a3408489e87c026ab68a214c.

fgrzadkowski · 2015-12-29T11:46:30Z

@mikedanese To be hones I like the new approach more :)

@zmerlynn I have updated this PR to also build and push docker image for hyperkube

luxas · 2015-12-29T11:54:28Z

build/common.sh

+    "kube-controller-manager"
+    "kube-scheduler"
+    "kube-proxy"
+    "hyperkube"


What about kubelet? Just asking

Kubelet is not running in docker container yet (I'm working on it...)

k8s-bot · 2015-12-29T12:10:12Z

GCE e2e test build/test passed for commit b207cc80a40c2a8a98b55df26848b7631a235cd2.

luxas · 2016-01-04T18:53:48Z

cluster/images/hyperkube/Makefile

@@ -13,6 +16,12 @@ TEMP_DIR:=$(shell mktemp -d)
 all: build

 build:
+ifndef REGISTRY


@fgrzadkowski Same comment here probably as: #19177 (comment)

k8s-bot · 2016-01-05T12:04:47Z

GCE e2e test build/test passed for commit e7e8c5a.

zmerlynn · 2016-01-08T18:56:59Z

@k8s-bot test this

@fgrzadkowski Sorry, I've been on holidays and sick. Looking soon.

luxas · 2016-01-08T19:00:10Z

This will be great to have merged 👍

zmerlynn · 2016-01-08T19:19:02Z

The Travis failure is weird. Kicking forcibly.

k8s-bot · 2016-01-08T19:55:29Z

GCE e2e build/test failed for commit e7e8c5a.

gmarek · 2016-01-11T10:39:29Z

#19467
@k8s-bot test this

k8s-bot · 2016-01-11T11:20:38Z

GCE e2e test build/test passed for commit e7e8c5a.

bgrant0607 · 2016-01-11T22:44:24Z

cc @david-mcmahon

k8s-github-robot · 2016-01-12T04:22:21Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-01-12T04:55:35Z

GCE e2e test build/test passed for commit e7e8c5a.

k8s-github-robot · 2016-01-12T04:56:00Z

Automatic merge from submit-queue

Auto commit by PR queue bot

luxas · 2016-01-24T15:09:14Z

build/common.sh

+
+  for arch in "${archs[@]}"; do
+    for binary in "${binaries[@]}"; do
+      local docker_target="${KUBE_DOCKER_REGISTRY}/${binary}-${arch}:${KUBE_DOCKER_IMAGE_TAG}"


@fgrzadkowski @mikedanese @zmerlynn
This creates compability issues when it doesn't push hyperkube only, it just pushes hyperkube-arch...
I assume we need to support hyperkube only until all guides etc. are updated.

…-#19061-upstream-release-1.1 Automated cherry pick of #19061

…ry-pick-of-#19061-upstream-release-1.1 Revert "Automated cherry pick of #19061"

…ry-pick-of-#19061-upstream-release-1.1 Automated cherry pick of kubernetes#19061

…mated-cherry-pick-of-#19061-upstream-release-1.1 Revert "Automated cherry pick of kubernetes#19061"

…ry-pick-of-#19061-upstream-release-1.1 Automated cherry pick of kubernetes#19061

…mated-cherry-pick-of-#19061-upstream-release-1.1 Revert "Automated cherry pick of kubernetes#19061"

googlebot added the cla: yes label Dec 23, 2015

k8s-github-robot assigned zmerlynn Dec 23, 2015

k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2015

fgrzadkowski force-pushed the release_docker branch from 7cb6d74 to 3f939af Compare December 23, 2015 15:13

luxas reviewed Dec 25, 2015
View reviewed changes

luxas mentioned this pull request Dec 29, 2015

Similar project awassink/k8s-on-rpi#1

Open

fgrzadkowski force-pushed the release_docker branch from 3f939af to f46ed7e Compare December 29, 2015 11:12

fgrzadkowski force-pushed the release_docker branch from f46ed7e to b207cc8 Compare December 29, 2015 11:44

luxas reviewed Dec 29, 2015
View reviewed changes

This was referenced Dec 30, 2015

Add docker images for kubelet and kubelet-checker. #19177

Closed

Containerized cluster cannot mount default secrets #18239

Closed

huggsboson mentioned this pull request Jan 4, 2016

Run kubelet in dockerized clusters via nsenter. #19069

Closed

luxas reviewed Jan 4, 2016
View reviewed changes

Push docker images for cluster components during release.

e7e8c5a

fgrzadkowski force-pushed the release_docker branch from b207cc8 to e7e8c5a Compare January 5, 2016 11:36

luxas mentioned this pull request Jan 7, 2016

[Proposal] Make Kubernetes run on ARM devices #17981

Closed

17 tasks

zmerlynn closed this Jan 8, 2016

zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2016

k8s-github-robot pushed a commit that referenced this pull request Jan 12, 2016

Merge pull request #19061 from fgrzadkowski/release_docker

cc7acc0

Auto commit by PR queue bot

k8s-github-robot merged commit cc7acc0 into kubernetes:master Jan 12, 2016

david-mcmahon mentioned this pull request Jan 13, 2016

New docker images push breaks build/push-official-release.sh script #19623

Closed

david-mcmahon mentioned this pull request Jan 21, 2016

Automated cherry pick of #19061 #19935

Merged

luxas reviewed Jan 24, 2016
View reviewed changes

ikehz pushed a commit that referenced this pull request Jan 27, 2016

Merge pull request #19935 from david-mcmahon/automated-cherry-pick-of…

6e51666

…-#19061-upstream-release-1.1 Automated cherry pick of #19061

ikehz pushed a commit that referenced this pull request Jan 27, 2016

Revert "Automated cherry pick of #19061"

ac09e69

ikehz pushed a commit that referenced this pull request Jan 27, 2016

Merge pull request #20236 from kubernetes/revert-19935-automated-cher…

38a9a23

…ry-pick-of-#19061-upstream-release-1.1 Revert "Automated cherry pick of #19061"

ikehz mentioned this pull request Jan 28, 2016

Make #19061 backward-compatible #20047

Closed

2 tasks

This was referenced Jan 30, 2016

Official ARM builds for every new release #19769

Merged

All hyperkube and hyperkube-amd64 images should be pushed #20235

Closed

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Merge pull request kubernetes#19935 from david-mcmahon/automated-cher…

58f6a84

…ry-pick-of-#19061-upstream-release-1.1 Automated cherry pick of kubernetes#19061

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Revert "Automated cherry pick of kubernetes#19061"

f5ac027

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Merge pull request kubernetes#20236 from kubernetes/revert-19935-auto…

fae4b29

…mated-cherry-pick-of-#19061-upstream-release-1.1 Revert "Automated cherry pick of kubernetes#19061"

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Merge pull request kubernetes#19935 from david-mcmahon/automated-cher…

88a5759

…ry-pick-of-#19061-upstream-release-1.1 Automated cherry pick of kubernetes#19061

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Revert "Automated cherry pick of kubernetes#19061"

a0f047d

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Merge pull request kubernetes#20236 from kubernetes/revert-19935-auto…

9f3ac8b

…mated-cherry-pick-of-#19061-upstream-release-1.1 Revert "Automated cherry pick of kubernetes#19061"

Push server docker images during the release (attempt 2) #19061

Push server docker images during the release (attempt 2) #19061

Uh oh!

Conversation

fgrzadkowski commented Dec 23, 2015

Uh oh!

k8s-github-robot commented Dec 23, 2015

Uh oh!

k8s-bot commented Dec 23, 2015

Uh oh!

k8s-bot commented Dec 23, 2015

Uh oh!

fgrzadkowski commented Dec 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikedanese commented Dec 28, 2015

Uh oh!

k8s-bot commented Dec 29, 2015

Uh oh!

fgrzadkowski commented Dec 29, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-bot commented Dec 29, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-bot commented Jan 5, 2016

Uh oh!

zmerlynn commented Jan 8, 2016

Uh oh!

luxas commented Jan 8, 2016

Uh oh!

zmerlynn commented Jan 8, 2016

Uh oh!

k8s-bot commented Jan 8, 2016

Uh oh!

gmarek commented Jan 11, 2016

Uh oh!

k8s-bot commented Jan 11, 2016

Uh oh!

bgrant0607 commented Jan 11, 2016

Uh oh!

k8s-github-robot commented Jan 12, 2016

Uh oh!

k8s-bot commented Jan 12, 2016

Uh oh!

k8s-github-robot commented Jan 12, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!