build: move some of hack/lib/ into a new cluster/lib/ #19086
Conversation
|
GCE e2e test build/test passed for commit af04cc72e92cb490f9aa74b209d7c2ead4d455dc. |
|
ping @zmerlynn |
|
Glancing at the existing contents, the intent of |
|
@zmerlynn can we move hack/lib/ into cluster? that would mean build/ would have to depend on cluster (which doesn't seem like a big deal). |
|
Alternately, we create some common ground somewhere, but I don't know where. Maybe for simplification that's |
|
Labelling this PR as size/M |
|
Change the commit message / PR? Otherwise LGTM. (I know you didn't say PTAL yet, but I was scanning PRs.) |
7220c46 to
c111819
Compare
|
@zmerlynn updated commit and description PTAL |
|
GCE e2e build/test failed for commit c098f9a4fb4e36666145c2b3c3988c0e9e1ca60c. |
|
GCE e2e build/test failed for commit 1f90f5a350a03b6863c164f6523d86f0150792e4. |
Some functionality in hack/lib is currently depended on by cluster/common.sh so kube-up from the full release tar (which does not include hack/) is currently broken. With this PR we create cluster/lib/ and move the necessary bits from hack/ over to get kube-up working again. Fixes: 96d1b8d Signed-off-by: Mike Danese <mikedanese@google.com>
|
GCE e2e test build/test passed for commit 22cfa5e. |
|
@k8s-bot unit test this |
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 22cfa5e. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Some functionality in hack/lib is currently depended on by cluster/common.sh
so kube-up from the full release tar (which does not include hack/) is currently
broken. With this PR we create cluster/lib/ and move the necessary bits from
hack/ over to get kube-up working again.
https://github.com/kubernetes/kubernetes/blob/master/cluster/common.sh#L27-L28
Fixes: 96d1b8d