Skip to content

Conversation

costinm
Copy link
Contributor

@costinm costinm commented Sep 19, 2017

Scripts cleaned up and migrated from proxy.

Location and name of release files may still change (and only one file made it to current release candidate).

Added example scripts for installing bookinfo components on a cluster extension (VM) 

function istioCopyBuildFiles() {
local ISTIO_IO=${ISTIO_BASE:-${GOPATH:-$HOME/go}}/src/istio.io
local ISTIO_FILES=${ISTIO_FILES:-.}
local ISTIO_FILES=${ISTIO_FILES:-$ISTIO_IO/istio/bazel-bin/vm}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't you rename this already ? ISTIO_STAGING_DIR


cat <<EOF | mysql -u root -ppassword
USE test;
update ratings set rating=$RATING where reviewid=1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cute.
though you can put test as mysql arg and avoid the use test and you can also put the update as a -e all in 1 line:

mysql -u root -ppassword test -e "update ratings set rating=$RATING where reviewid=1;

(and having the user and password hardcoded is a bit scary)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you can pass a single command - but I think the other style is more readable and can be used for more generic setups.

Nothing I can do at this point about the hardcoded password. I believe mongodb sample is also wide open and relies only on firewall. If auth is enabled - mTLS will take care of it.

@ldemailly
Copy link
Member

ldemailly commented Sep 19, 2017

where is the istioctl register part btw ?

Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting it in your queue. small change and istioctl register question and good to go

@costinm
Copy link
Contributor Author

costinm commented Sep 20, 2017

istioctl is not part of the script - there is no point to wrap it with a function that takes the same parameters.

The previous kubectl method to add the service was in the script because it requires few commands and a more complex syntax.

@costinm costinm requested a review from ZackButcher September 20, 2017 21:40
Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me to go in.

@ZackButcher
Copy link
Contributor

Shriram should still give it a thumbs up first though.

Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the callers for these scripts? I am also unclear about the objective here, to run details and yet be installing MySQL.

There is a wildcard chmod that needs to be cleaned up. And better to move the cluster ext scripts to a scripts folder.

@@ -189,18 +189,19 @@ function istioBootstrapVM() {

istio_provision_certs $SA

local ISTIO_FILES=${ISTIO_FILES:-.}
local ISTIO_IO=${ISTIO_BASE:-${GOPATH:-$HOME/go}}/src/istio.io
local ISTIO_STAGING=${ISTIO_STAGING:-$ISTIO_IO/istio/bazel-bin/vm}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we allowe to create our own directories under bazel folders ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory (and all of the other bazel-* dirs) is actually a symlink to $HOME/.cache/bazel/... - we should be able to create directories there, but they're ephemeral.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding is the script will be packaged in our istio release binary, correct? If so, is bazel stuff mandatory? I'd hope not, if so, i would prefer a default dir not mention bazel to avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we can create files and dirs - this can go away once we have all .deb files available
for download.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved - will just use the structure that downloadIstio creates ( and updated the script to get the files we need ).

Long term the deb files will be in an apt repo, and we can include the helpers for VM in the debian ( a bit too late for Monday, will try to have a PR ready just in case )

mkdir -p $ISTIO_STAGING
pushd $ISTIO_STAGING

curl ${CURL_OPTIONS:-} https://storage.googleapis.com/istio-release/releases/$ISTIO_VERSION/deb/istio-auth-node-agent-release.deb > istio-auth-node-agent.deb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name the files with the versions ? Makes it easier to revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will complicate the script that runs on the machine ( would need to take istio version ).
Reverting is 'apt-get remove istio-auth' ( i.e. the name of the package, without version).

This is all temporary - we will need to setup the apt-get and signing, but I don't see it
happening in 0.2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i meant istio-auth-agent-${ISTIO_VERSION}.deb .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the release names - will be istio-ISTIO_VERSION/... ( we can change in the next release )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well - in the next release I hope we'll not download .deb by hand...

curl ${CURL_OPTIONS:-} https://storage.googleapis.com/istio-release/releases/$ISTIO_VERSION/deb/istio-auth-node-agent-release.deb > istio-auth-node-agent.deb
curl ${CURL_OPTIONS:-} https://storage.googleapis.com/istio-release/releases/$ISTIO_VERSION/deb/istio-proxy-envoy-release.deb > istio-proxy-envoy.deb
curl ${CURL_OPTIONS:-} https://storage.googleapis.com/istio-release/releases/$ISTIO_VERSION/deb/istio-agent-release.deb > istio-agent.deb
chmod +w *.deb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bad idea. Esp wildcard like these. Maybe istio-*.deb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update it - probably not needed, not sure what the default perm will be on the curl.

The problem with r/o .deb is that "scp ..." fails the second time. May not be an issue for
regular users who just try this once (and long term will go away when we have proper
apt repos)

#
################################################################################

# Script to run on a VM with VPC connectivity to the cluster, to prepare the DB and details app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why details app? I thought we were just running MySQL here. Besides ratings is the one that accesses db. Not details

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPC connectivity is confusing as it is not required. can we reword it to network connectivity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think ratings should run on k8s, to show it can access a DB over TCP. That's
the main use case.

Details is to show http works - and can run either on the VM or on k8s. Why - simply easiest to install (just ruby dep). I tried the others - any can be run, and we can even have a demo with all components on VMs, but this seems the lighter.

On wording - 'network connectivity' is also pretty confusing.

@@ -0,0 +1,73 @@
#!/bin/bash
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really liking the concept of polluting bookinfo root. If possible move to dedicated folder. Also, call it demo_cluster_ext.sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just _bookinfo_vm_svc.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - how about cluster_ext folder ? We need some way to help automate running
bookinfo on a VM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster_ext or scripts.. your call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used clusterex for now ( since it's not clear if 'ext' or 'exp' will be used :-)

fi
ruby details/details.rb 9080 > details.log 2>&1 &
echo $! > $app.pid
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this I am really confused. I thought your initial PRs were just testing. It kind of distorts the story if we say we are running in a kube pod, but let's take same app and run in a vm. The story is much more powerful, streamlined and memorable if we just say, assume you now have to talk to legacy db vm or a legacy service that you have not seen yet so far in the example flow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion - this is not for testing, but to allow people to see that some services can run on the VM, and you can have a 'mesh' of services that may include components running on-prem.

I don't mind removing (or not showing) the details on the VM, AFAIK it was part of the demo use case - but I agree the DB is more compelling.

Note that 'rating' won't work on the VM, since we don't yet support labels (like version)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its still not too late. We can whip up a simple Go/python based price service that talks http to bookinfo, and its a very small change in the UI to show price (fits nicely with book "info"). This service can talk to the DB, and let it run in the VM itself

@@ -0,0 +1,111 @@
#!/bin/bash
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we definitely need a folder here. Too many scripts in the root. I asked Greg to move consul stuff to separate folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe be good to move both consul and 'simple' VMs to same folder ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. rule formats are different. see bookinfo consul folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this completely - the setup extension instructions will take care of all that is needed, we only need the script
to setup mysql and whatever app we want to show.

For now I'm keeping details - but I agree a go app will be better ( for 0.3)

if [[ ${1:-} == "install" ]] ; then
istioInstallBookinfo
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is calling the updateRatings function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User or whoever is showing a demo ( to show that the DB is used, and you can still connect to it from the VM)


}

# Helper to create the raw VM. You can also use an existing VM, or create using the UI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Raw.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

# Helper to create the raw VM. You can also use an existing VM, or create using the UI.
# Currently uses gcloud - can be extended with other environments.
function istioVMInit() {
# TODO: check if it exists and do "reset", to speed up the script.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to createGCloudVM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about remove this completely - and add a comment that user should create the VM using the UI or CLI ? It may be convenient as a function - but it's pretty slow.
The only reason I kept it is to make sure firewall on 22 is set, and a deb/ubuntu image is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. remove and we explain steps in doc.

Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also give generate usage guideline of these scripts? It is not super clear how they are used in which sequence, and the requirements before using it.

@@ -189,18 +189,19 @@ function istioBootstrapVM() {

istio_provision_certs $SA

local ISTIO_FILES=${ISTIO_FILES:-.}
local ISTIO_IO=${ISTIO_BASE:-${GOPATH:-$HOME/go}}/src/istio.io
local ISTIO_STAGING=${ISTIO_STAGING:-$ISTIO_IO/istio/bazel-bin/vm}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding is the script will be packaged in our istio release binary, correct? If so, is bazel stuff mandatory? I'd hope not, if so, i would prefer a default dir not mention bazel to avoid confusion.


mkdir -p $ISTIO_STAGING
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is source required? The comment isn't clear and the code seems to indicate yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this builds the .deb files from source. Will go away once we test the download of
release .deb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this part, download from release artifacts.

function istioDownloadVMFiles() {
local ISTIO_IO=${ISTIO_BASE:-${GOPATH:-$HOME/go}}/src/istio.io
local ISTIO_STAGING=${ISTIO_STAGING:-$ISTIO_IO/istio/bazel-bin/vm}
local ISTIO_VERSION=${ISTIO_VERSION:-0.2.3}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not hard code version here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to have defaults - but I could source istio.version file ( since this will be part of the samples ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downloadIstio.sh (https://git.io/getIstio) also hardcodes the version, there is a TODO to update it automatically
one each release - when this is done we'll update here as well.

( in any case - removed this code, it is now part of downloadIstio )

#
################################################################################

# Script to run on a VM with VPC connectivity to the cluster, to prepare the DB and details app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPC connectivity is confusing as it is not required. can we reword it to network connectivity?

Copy link
Contributor Author

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL.

downloadIstio.sh Outdated
echo "Downloading $NAME from $URL ..."
curl -L "$URL" | tar xz

# Current URL for the debian files artifacts. Will be replaced by a proper apt repo.
DEBURL=http://gcsweb.istio.io/gcs/istio-release/releases/${ISTIO_VERSION}/deb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's please not touch this file

downloadIstio.sh Outdated
curl -L ${DEBURL}/istio-agent-release.deb > istio-${ISTIO_VERSION}/istio-agent-release.deb
curl -L ${DEBURL}/istio-auth-node-agent-release.deb > istio-${ISTIO_VERSION}/istio-auth-node-agent-release.deb
curl -L ${DEBURL}/istio-proxy-release.deb > istio-${ISTIO_VERSION}/istio-proxy-release.deb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally missed this.. downloadIstio is linked to our vanity URL. If anything, can you add a comment to this file to not modify anything except the version ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that too modify by hand.. Say its linked to getIstio.sh

Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. You have some stray YAML files. Also rename run_extensions.sh to setupApps.sh and undo mods to downloadIstio.sh

# Copyright 2017 Istio Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats this file for? And it has personal images as well.

@@ -0,0 +1,75 @@
#!/bin/bash
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup_app.sh

@@ -0,0 +1,17 @@
type: route-rule
name: ratings-test-v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file? We have a copy in bookinfo/kube/...

@rshriram
Copy link
Member

/lgtm

@istio-merge-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @costinm @rshriram

@@ -57,6 +57,14 @@ function istioInstall() {
chown -R istio-proxy /etc/certs
chown -R istio-proxy /var/lib/istio/envoy

ISTIO_VERSION=${ISTIO_VERSION:-0.2.4}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source istio.VERSION instead ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where ? This will be curl ... |sh

@andraxylia
Copy link
Contributor

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, rshriram

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [andraxylia,rshriram]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 1ec4132 into master Sep 25, 2017
@ldemailly ldemailly deleted the costin-bookinfo branch October 3, 2017 22:07
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
Former-commit-id: 468f2e1ed80dd9df026c2aac56253cdfe8391f3d
rshriram pushed a commit that referenced this pull request Oct 30, 2017
Automatic merge from submit-queue

Fixes for the common vm utils and scripts to install bookinfo

Scripts cleaned up and migrated from proxy.

Location and name of release files may still change (and only one file made it to current release candidate).

```release-note
Added example scripts for installing bookinfo components on a cluster extension (VM) 
```

Former-commit-id: 1ec4132
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
Former-commit-id: 67c41b8de5fee747d9d6b1b5497b5c414ad8bb2f
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
)

Automatic merge from submit-queue

Fixes for the common vm utils and scripts to install bookinfo

Scripts cleaned up and migrated from proxy.

Location and name of release files may still change (and only one file made it to current release candidate).

```release-note
Added example scripts for installing bookinfo components on a cluster extension (VM) 
```

Former-commit-id: 1ec4132
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* ingress separation

* remove stale istioct stuff

* code shuffle

* finish separation

* typo

* address comments

* exclude ingress from race test
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Automatic merge from submit-queue

Fixes for the common vm utils and scripts to install bookinfo

Scripts cleaned up and migrated from proxy.

Location and name of release files may still change (and only one file made it to current release candidate).

```release-note
Added example scripts for installing bookinfo components on a cluster extension (VM) 
```

Former-commit-id: 1ec4132
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Doc fixes.

* Add high-level overview and diagrams for MCP (istio#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (istio#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (istio#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (istio#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (istio#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced66f620fb60b0d5e18af916567e313a0109.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (istio#811)"

This reverts commit 5f14eadd since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc5 which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (istio#810)

* update istio/tools (istio#815)

* Revert "Revert "Generate separate HTML page per proto under networking (istio#811)"" (istio#818)

* Minor updates for building docker images. (istio#817)

* Add spell checking for docs. (istio#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (istio#820)

* Doc fixes. (istio#821)

* Proxy config: Add tls_certs_to_watch field (istio#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (istio#824)" (istio#825)

This reverts commit e613e358ae8d4f331dd48904b0a2b176e11bf7f5.

* Update gateway and sidecar hosts doc (istio#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (istio#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (istio#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue istio#12181

* add lock file

* Hosts are not ignored in ServiceEntry for HTTPs (istio#833)

* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate

* make mixer config marshal deterministic (istio#846)

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Fix some doc errors. (istio#854)

This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.

* Fix two more broken links. (istio#856)

* Fix CRD examples for release-1.1 (istio#859)

* fix MeshNetworks demo (istio#841)

* fix MeshNetworks demo

* generate

* update

* last minute doc fixes (istio#865)

Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>

* Clarify comment for server_name field in Mixer oop auth config (istio#800)

* add mixerclient config to istio.io reference docs (istio#827)

* Envoyfilter docs fix (istio#867)

* Tweaks to get the mixer client config docs to be published. (istio#868)

* Change where the Mixer client docs are published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants