Remove unused configmap from ingress and egress #815

kyessenov · 2017-09-14T22:22:50Z

Release note:

NONE

ldemailly · 2017-09-14T22:47:19Z

thanks for the offline explanation, this seems good (removing unused stuff) but has the potential for 503s coming back (touching ingress) - how do we confirm/test that in our shared cluster just to confirm the right pilot is used by the right ingress ? (type /retest in multiple copies of this PR ?)

kyessenov · 2017-09-14T22:50:45Z

503 were caused by two pilots picking up same ingress resources. That's a separate issue and that is fixed by passing "-a" flag to istio-pilot YAML (see that rewrite in e2e framework).
This puts "istio-pilot" as a DNS name to pilot. That means ingress only talks to pilot in the same namespace.

rshriram · 2017-09-15T00:34:42Z

I am okay with the secret thingy removal. Neutral about the config map removal.

rshriram

I am okay with the secret thingy removal. Neutral about the config map removal. Might add it at sometime in future, but we can always add.

kyessenov · 2017-09-15T00:52:48Z

/lgtm

istio-testing · 2017-09-15T00:52:49Z

@kyessenov: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyessenov · 2017-09-15T00:53:03Z

@rshriram type lgtm or it doesn't get merged

rshriram · 2017-09-15T02:32:30Z

/lgtm

istio-merge-robot · 2017-09-15T02:33:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyessenov, rshriram

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [rshriram]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

ldemailly · 2017-09-15T02:49:30Z

let the bot do it if possible, as there was an auto PR about to get merged which didn't (#818 )

Edit: 818 went in !

ldemailly · 2017-09-15T02:59:10Z

this is a step toward #632 btw, thanks

ldemailly · 2017-09-15T03:14:40Z

hey looks like you didn't run updateVersion!

see https://github.com/istio/istio/pull/819/files

andraxylia · 2017-09-15T05:15:54Z

/lgtm the config map removal
I do not understand the secrets removal, this was added recently by @myidpt

updateVersion was not run, but it's ok now, the bot came next and ran it anyway.

…pters can determine the type of the payload they're pushing to the backend. (istio#815) Former-commit-id: 6231c80fb2549d31b6e6475e843ed1e95b17cabf

Former-commit-id: 82195b7

…pters can determine the type of the payload they're pushing to the backend. (#815) Former-commit-id: b52935b7c2dfc5235a7133c22e445dee85849ed2

Former-commit-id: 82195b7

Extract the common path prefix as scopesPath. Also this introduces url.PathEscape which should escape the components with ill-formed paths.

Former-commit-id: 82195b7

* Doc fixes. * Add high-level overview and diagrams for MCP (istio#805) * document MCP * add additional note on NACK behavior * add a note about ignoring stale nonces * Add envoy metrics service configuration to ProxyConfig (istio#803) * Add envoy metrics service configuration to ProxyConfig Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API. * Update proto.lock * Reorder metrics_service_address just after statsd_udp_address * Update comment in the authN API to match with 1.1 behavior (istio#808) * Rename metrics_service_address to clarify that it is for Envoy's API (istio#809) Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API. * Generate separate HTML page per proto under networking (istio#811) * Generate separate pages for each networking proto Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * update Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * tweaks Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * Fix interdoc references * separate doc and go gen * change dash to underscore * fix * more fixes * makefile fix Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * remove bad target * Revert "change dash to underscore" This reverts commit 7fbced66f620fb60b0d5e18af916567e313a0109. * final update Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * Revert "Generate separate HTML page per proto under networking (istio#811)" This reverts commit 5f14eadd since it breaks the ability to generate reference docs in istio.io * Update to latest tools. * Revert "Update to latest tools." This reverts commit 231fadc5 which I accidentally pushed to the wrong place. * fix mcp update error diagram (istio#810) * update istio/tools (istio#815) * Revert "Revert "Generate separate HTML page per proto under networking (istio#811)"" (istio#818) * Minor updates for building docker images. (istio#817) * Add spell checking for docs. (istio#819) * Add a bunch of words to the custom dictionary. * Document exportTo restrictions (istio#820) * Doc fixes. (istio#821) * Proxy config: Add tls_certs_to_watch field (istio#824) * Proxy config: Add tls_certs_to_watch field * Address PR comment * Revert "Proxy config: Add tls_certs_to_watch field (istio#824)" (istio#825) This reverts commit e613e358ae8d4f331dd48904b0a2b176e11bf7f5. * Update gateway and sidecar hosts doc (istio#826) * Update gateway and sidecar hosts doc * regen * review comments * Update API docs (service entry, gateway, sidecar) (istio#831) * Update sidecar and gateway docs Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * gen docs Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * update service entry Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * updates Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * add configurable dns refresh rate to mesh for strict dns cluster, (istio#832) * add configurable dns refresh rate to mesh for strict dns cluster, issue istio#12181 * add lock file * Post-merge generation

* Doc fixes. * Add high-level overview and diagrams for MCP (istio#805) * document MCP * add additional note on NACK behavior * add a note about ignoring stale nonces * Add envoy metrics service configuration to ProxyConfig (istio#803) * Add envoy metrics service configuration to ProxyConfig Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API. * Update proto.lock * Reorder metrics_service_address just after statsd_udp_address * Update comment in the authN API to match with 1.1 behavior (istio#808) * Rename metrics_service_address to clarify that it is for Envoy's API (istio#809) Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API. * Generate separate HTML page per proto under networking (istio#811) * Generate separate pages for each networking proto Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * update Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * tweaks Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * Fix interdoc references * separate doc and go gen * change dash to underscore * fix * more fixes * makefile fix Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * remove bad target * Revert "change dash to underscore" This reverts commit 7fbced66f620fb60b0d5e18af916567e313a0109. * final update Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * Revert "Generate separate HTML page per proto under networking (istio#811)" This reverts commit 5f14eadd since it breaks the ability to generate reference docs in istio.io * Update to latest tools. * Revert "Update to latest tools." This reverts commit 231fadc5 which I accidentally pushed to the wrong place. * fix mcp update error diagram (istio#810) * update istio/tools (istio#815) * Revert "Revert "Generate separate HTML page per proto under networking (istio#811)"" (istio#818) * Minor updates for building docker images. (istio#817) * Add spell checking for docs. (istio#819) * Add a bunch of words to the custom dictionary. * Document exportTo restrictions (istio#820) * Doc fixes. (istio#821) * Proxy config: Add tls_certs_to_watch field (istio#824) * Proxy config: Add tls_certs_to_watch field * Address PR comment * Revert "Proxy config: Add tls_certs_to_watch field (istio#824)" (istio#825) This reverts commit e613e358ae8d4f331dd48904b0a2b176e11bf7f5. * Update gateway and sidecar hosts doc (istio#826) * Update gateway and sidecar hosts doc * regen * review comments * Update API docs (service entry, gateway, sidecar) (istio#831) * Update sidecar and gateway docs Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * gen docs Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * update service entry Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * updates Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * add configurable dns refresh rate to mesh for strict dns cluster, (istio#832) * add configurable dns refresh rate to mesh for strict dns cluster, issue istio#12181 * add lock file * Hosts are not ignored in ServiceEntry for HTTPs (istio#833) * Hosts are not ignored in ServiceEntry for HTTPs * Clarify * Reword * Generate protos * Address code review comments * Fix typo * generate * make mixer config marshal deterministic (istio#846) Signed-off-by: Kuat Yessenov <kuat@google.com> * Fix some doc errors. (istio#854) This started out to just fix a bad link to unblock work on istio.io, but I ended up fixing a bunch of typos/incorrect format throughout. * Fix two more broken links. (istio#856) * Fix CRD examples for release-1.1 (istio#859) * fix MeshNetworks demo (istio#841) * fix MeshNetworks demo * generate * update * last minute doc fixes (istio#865) Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com> * Clarify comment for server_name field in Mixer oop auth config (istio#800) * add mixerclient config to istio.io reference docs (istio#827) * Envoyfilter docs fix (istio#867) * Tweaks to get the mixer client config docs to be published. (istio#868) * Change where the Mixer client docs are published.

remove unused configmap

8b2cec3

kyessenov requested review from ldemailly and andraxylia September 14, 2017 22:22

googlebot added the cla: yes label Sep 14, 2017

istio-merge-robot added the release-note-none label Sep 14, 2017

kyessenov requested review from mandarjog and douglas-reid September 14, 2017 22:24

kyessenov mentioned this pull request Sep 14, 2017

ConfigMap copy issue istio/old_pilot_repo#1272

Closed

rshriram approved these changes Sep 15, 2017

View reviewed changes

costinm approved these changes Sep 15, 2017

View reviewed changes

istio-testing assigned rshriram Sep 15, 2017

istio-testing added the lgtm label Sep 15, 2017

istio-merge-robot added the approved label Sep 15, 2017

rshriram merged commit 82195b7 into istio:master Sep 15, 2017

ldemailly mentioned this pull request Sep 15, 2017

pre submit should catch that install/updateVersion.sh must be a noop #643

Closed

rshriram pushed a commit that referenced this pull request Oct 30, 2017

remove unused configmap (#815)

b875959

Former-commit-id: 82195b7

vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017

remove unused configmap (istio#815)

c23565f

Former-commit-id: 82195b7

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Add 'adapter' and 'descriptor' command to istioctl mixer. (#815)

c5ebfdc

Extract the common path prefix as scopesPath. Also this introduces url.PathEscape which should escape the components with ill-formed paths.

mandarjog pushed a commit that referenced this pull request Nov 2, 2017

remove unused configmap (#815)

7f55f13

Former-commit-id: 82195b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused configmap from ingress and egress #815

Remove unused configmap from ingress and egress #815

Uh oh!

kyessenov commented Sep 14, 2017 •

edited

Loading

Uh oh!

ldemailly commented Sep 14, 2017

Uh oh!

kyessenov commented Sep 14, 2017

Uh oh!

rshriram commented Sep 15, 2017

Uh oh!

rshriram left a comment

Uh oh!

kyessenov commented Sep 15, 2017

Uh oh!

istio-testing commented Sep 15, 2017

Uh oh!

kyessenov commented Sep 15, 2017

Uh oh!

rshriram commented Sep 15, 2017

Uh oh!

istio-merge-robot commented Sep 15, 2017

Uh oh!

ldemailly commented Sep 15, 2017 •

edited

Loading

Uh oh!

ldemailly commented Sep 15, 2017

Uh oh!

ldemailly commented Sep 15, 2017

Uh oh!

andraxylia commented Sep 15, 2017

Uh oh!

Uh oh!

Remove unused configmap from ingress and egress #815

Remove unused configmap from ingress and egress #815

Uh oh!

Conversation

kyessenov commented Sep 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldemailly commented Sep 14, 2017

Uh oh!

kyessenov commented Sep 14, 2017

Uh oh!

rshriram commented Sep 15, 2017

Uh oh!

rshriram left a comment

Choose a reason for hiding this comment

Uh oh!

kyessenov commented Sep 15, 2017

Uh oh!

istio-testing commented Sep 15, 2017

Uh oh!

kyessenov commented Sep 15, 2017

Uh oh!

rshriram commented Sep 15, 2017

Uh oh!

istio-merge-robot commented Sep 15, 2017

Uh oh!

ldemailly commented Sep 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldemailly commented Sep 15, 2017

Uh oh!

ldemailly commented Sep 15, 2017

Uh oh!

andraxylia commented Sep 15, 2017

Uh oh!

Uh oh!

kyessenov commented Sep 14, 2017 •

edited

Loading

ldemailly commented Sep 15, 2017 •

edited

Loading