Skip to content

Conversation

rvkubiak
Copy link
Contributor

@rvkubiak rvkubiak commented Sep 1, 2017

Mark the manual release process as deprecated

NONE

Mark the manual release process as deprecated
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly merged commit 015ef1d into master Sep 4, 2017
@ldemailly ldemailly deleted the rvkubiak-patch-2 branch September 4, 2017 21:10
@istio-testing
Copy link
Collaborator

@rvkubiak: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-no_rbac-auth.sh c67d457 link /test e2e-suite-no_rbac-auth
prow/e2e-suite-rbac-no_auth.sh c67d457 link /test e2e-suite-rbac-no_auth
prow/e2e-suite-rbac-auth.sh c67d457 link /test e2e-suite-rbac-auth
prow/e2e-suite-no_rbac-no_auth.sh c67d457 link /test e2e-suite-no_rbac-no_auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rshriram pushed a commit that referenced this pull request Oct 30, 2017
Mark the manual release process as deprecated

Former-commit-id: 015ef1d
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
Mark the manual release process as deprecated

Former-commit-id: 015ef1d
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Mark the manual release process as deprecated

Former-commit-id: 015ef1d
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Major change here is a new panel added to mesh dashboard and galley
metrics name fixes
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Add option to use LightStep as a tracing backend.

* Update docs: LightstepCollector takes precedence over zipkin conf

* Add parameter for cacert to use when authenticating LightStep Satellite

* Add more detail to ca cert comment

* Consolidate tracing config into its own message
luksa added a commit to luksa/istio that referenced this pull request Apr 11, 2024
…Istio CNI (istio#688)

* [cni] MAISTRA-2132 Support deployment of multiple plugin versions in Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.

  * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510)

    Because our CNI pod contains more than one container, and they write to
    the same directory, and they watch for changes on those directories,
    changes made by one container trigger the watch on the other, which will
    responde by copying the files to the directory, which will in turn
    trigger the watcher of the other container in an endless loop.

    This leads to high CPU usage on the node.

    This PR changes the logic to only monitor for files that have the
    desired prefix. Thus, for example, the 2.2 container will only react to
    changes to files whose names  start with "v2-2". This avoid this race
    condition and achieve the same end result.

* [cni] MAISTRA-2051 use correct UID/GID in istio-iptables

* OSSM-2082 CNI installer now creates the net.d directory if necessary (istio#638)

* fix(lint): replaces deprecated pkg io/ioutil

* fix: reverts back to t.TempDir() calls

Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
Co-authored-by: rcernich <rcernich@redhat.com>
dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024
…Istio CNI (istio#688)

* [cni] MAISTRA-2132 Support deployment of multiple plugin versions in Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.

  * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510)

    Because our CNI pod contains more than one container, and they write to
    the same directory, and they watch for changes on those directories,
    changes made by one container trigger the watch on the other, which will
    responde by copying the files to the directory, which will in turn
    trigger the watcher of the other container in an endless loop.

    This leads to high CPU usage on the node.

    This PR changes the logic to only monitor for files that have the
    desired prefix. Thus, for example, the 2.2 container will only react to
    changes to files whose names  start with "v2-2". This avoid this race
    condition and achieve the same end result.

* [cni] MAISTRA-2051 use correct UID/GID in istio-iptables

* OSSM-2082 CNI installer now creates the net.d directory if necessary (istio#638)

* fix(lint): replaces deprecated pkg io/ioutil

* fix: reverts back to t.TempDir() calls

Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
Co-authored-by: rcernich <rcernich@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants