Skip to content

Conversation

sebastienvas
Copy link
Contributor

@sebastienvas sebastienvas commented May 15, 2017

This change is Reviewable

@istio-testing
Copy link
Collaborator

Jenkins job istio/presubmit passed

@sebastienvas sebastienvas merged commit bd22dae into istio:master May 15, 2017
zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
Clean up metrics related code: actually install the metrics manager in our inventory, populate some metric descriptor fields that were being skipped previously, fix some newly broken tests, and consolidate some of the duplicated test classes.


Former-commit-id: b6c74f11ce89637e7a130951d6032b7c169c7987
rshriram pushed a commit that referenced this pull request Oct 30, 2017
* Updating istio version

* Update istioctl url


Former-commit-id: bd22dae
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
Clean up metrics related code: actually install the metrics manager in our inventory, populate some metric descriptor fields that were being skipped previously, fix some newly broken tests, and consolidate some of the duplicated test classes.


Former-commit-id: 9ea6e904c71e5f200fc78109df7fd50dfc65aa02
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
* Updating istio version

* Update istioctl url


Former-commit-id: bd22dae
guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018
* egress services

* nits

* updates

* Egress route

* foreign services

* updates

* doc nits

* fixes

* updates, endpoints
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
There is already one exists with resources setting
luksa added a commit to luksa/istio that referenced this pull request Apr 26, 2021
istio#273)

To support the deployment of multiple CNI plugin versions, the name of the
executable that is invoked to set up the network namespace must be configurable.
luksa added a commit to luksa/istio that referenced this pull request Jun 30, 2021
…CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.
luksa added a commit to luksa/istio that referenced this pull request Feb 22, 2022
…Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.
luksa added a commit to luksa/istio that referenced this pull request Apr 29, 2022
…Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.
luksa added a commit to luksa/istio that referenced this pull request Sep 15, 2022
…Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.

  * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510)

    Because our CNI pod contains more than one container, and they write to
    the same directory, and they watch for changes on those directories,
    changes made by one container trigger the watch on the other, which will
    responde by copying the files to the directory, which will in turn
    trigger the watcher of the other container in an endless loop.

    This leads to high CPU usage on the node.

    This PR changes the logic to only monitor for files that have the
    desired prefix. Thus, for example, the 2.2 container will only react to
    changes to files whose names  start with "v2-2". This avoid this race
    condition and achieve the same end result.
luksa added a commit to luksa/istio that referenced this pull request Apr 11, 2024
…Istio CNI (istio#688)

* [cni] MAISTRA-2132 Support deployment of multiple plugin versions in Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.

  * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510)

    Because our CNI pod contains more than one container, and they write to
    the same directory, and they watch for changes on those directories,
    changes made by one container trigger the watch on the other, which will
    responde by copying the files to the directory, which will in turn
    trigger the watcher of the other container in an endless loop.

    This leads to high CPU usage on the node.

    This PR changes the logic to only monitor for files that have the
    desired prefix. Thus, for example, the 2.2 container will only react to
    changes to files whose names  start with "v2-2". This avoid this race
    condition and achieve the same end result.

* [cni] MAISTRA-2051 use correct UID/GID in istio-iptables

* OSSM-2082 CNI installer now creates the net.d directory if necessary (istio#638)

* fix(lint): replaces deprecated pkg io/ioutil

* fix: reverts back to t.TempDir() calls

Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
Co-authored-by: rcernich <rcernich@redhat.com>
dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024
…Istio CNI (istio#688)

* [cni] MAISTRA-2132 Support deployment of multiple plugin versions in Istio CNI (istio#271)

Includes:

  * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325)

  * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273)

    To support the deployment of multiple CNI plugin versions, the name of the
    executable that is invoked to set up the network namespace must be configurable.

  * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510)

    Because our CNI pod contains more than one container, and they write to
    the same directory, and they watch for changes on those directories,
    changes made by one container trigger the watch on the other, which will
    responde by copying the files to the directory, which will in turn
    trigger the watcher of the other container in an endless loop.

    This leads to high CPU usage on the node.

    This PR changes the logic to only monitor for files that have the
    desired prefix. Thus, for example, the 2.2 container will only react to
    changes to files whose names  start with "v2-2". This avoid this race
    condition and achieve the same end result.

* [cni] MAISTRA-2051 use correct UID/GID in istio-iptables

* OSSM-2082 CNI installer now creates the net.d directory if necessary (istio#638)

* fix(lint): replaces deprecated pkg io/ioutil

* fix: reverts back to t.TempDir() calls

Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
Co-authored-by: rcernich <rcernich@redhat.com>
fjglira pushed a commit to fjglira/istio that referenced this pull request Feb 10, 2025
…ter-merge_upstream_istio_master-6253864e

Automator: merge upstream changes to openshift-service-mesh/istio@master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants