Skip to content

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Apr 16, 2020

No description provided.

@ericvn ericvn requested a review from a team April 16, 2020 20:04
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 16, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2020
@ericvn ericvn added the do-not-merge Block automatic merging of a PR. label Apr 16, 2020
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2020
@ericvn ericvn removed the do-not-merge Block automatic merging of a PR. label Apr 17, 2020
@jwendell
Copy link
Member

@ericvn @howardjohn That test is kind of broken as it tries to use cni from master: https://github.com/istio/istio/blob/release-1.4/prow/lib.sh#L184

@ericvn ericvn added the do-not-merge Block automatic merging of a PR. label Apr 17, 2020
prow/lib.sh Outdated
@@ -184,7 +184,7 @@ function setup_kind_cluster() {
function cni_run_daemon_kind() {
echo 'Run the CNI daemon set'
ISTIO_CNI_HUB=${ISTIO_CNI_HUB:-gcr.io/istio-testing}
ISTIO_CNI_TAG=${ISTIO_CNI_TAG:-latest}
ISTIO_CNI_TAG=${ISTIO_CNI_TAG:-1.4-dev}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not enough as it's using an old and wrong chart below.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 17, 2020
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 17, 2020
@ericvn ericvn removed the do-not-merge Block automatic merging of a PR. label Apr 17, 2020
@istio-testing
Copy link
Collaborator

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
integ-mixer-k8s-tests_istio_release-1.4 6064000 link /test integ-mixer-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 884984a into istio:release-1.4 Apr 17, 2020
@ericvn ericvn deleted the updateDeps2 branch April 18, 2020 01:49
luksa pushed a commit to luksa/istio that referenced this pull request Jul 17, 2020
* authz: fix the validation for request.headers (istio#21284)

* manual backport of 21513 (istio#21514)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

* Fix PSP sample file to allow NET_RAW. (istio#21533)

* [release-1.4] remove use_downstream_protocol for gateway (istio#21727)

* remove use_downstream_protocol for gateway

* comment

* writing

Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>

* Update dependencies (istio#21765)

* Make iptables script and output consistent with golang (istio#21871)

Co-authored-by: knrc <knrc@users.noreply.github.com>

* [release-1.4] resign certificate (istio#22131)

* resign certificate

* test

Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>

* Stop linting links of 1.4 branch (istio#22132)

This is going to continue to break as istio.io changes. We already
disabled this on 1.5/master.

* [release-1.4] Build: Honor GOBUILDFLAGS variable also in test mode (istio#22171)

We already honor it in `go build`, we should do the same
in `go test`.

Manual backport of istio#22163

* Update base image for release 1.4 (istio#22165)

* Fix GOBUILDFLAGS usage in codecov scripts (istio#22182)

This variable needs to be set before used (set -u) and must not be
quoted, otherwise it will become an empty arg for go test if it's empty.

Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>

* Update proxy to pickup fixes for ISTIO-SECURITY-2020-003. (istio#22257)

* Fix extra .Value in deployment file for stackdriver tracing vars (istio#22506)

Co-authored-by: gargnupur <gargnupur@google.com>

* Update operator SHA (istio#22523)

* clone LbEndpoint to prevent data race (istio#22023) (istio#22528)

(cherry picked from commit fdc6dd4)

Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com>

* cni: update SHA (istio#22569)

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

* Make sure to use CNI 1.4 image when running tests under CNI (istio#23035)

* Make sure to use CNI 1.4 image when running tests under CNI

* Fix lint

* [release-1.4] Update dependencies with update_deps.sh (istio#23010)

* Update deps with update_deps.sh

* Dep updates again

* [release-1.4] Run update_deps.sh (istio#23051)

* Run update_deps.sh

Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08
since update_deps.sh was not updating it.

* Run go mod tidy

* Update with another cni change (istio#23061)

* [release-1.4] Fix Gateway helm chart for helm 3 (istio#23077)

* Fix Gateway helm chart for helm 3

Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception.

By nesting the if, the problem is resolved

* Also fix the role

Co-authored-by: Alex Nederlof <alex@nederlof.com>

Co-authored-by: Yangmin Zhu <ymzhu@google.com>
Co-authored-by: Rama Chavali <rama.rao@salesforce.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
Co-authored-by: Istio Automation <istio.testing@gmail.com>
Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>
Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>
Co-authored-by: knrc <knrc@users.noreply.github.com>
Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>
Co-authored-by: John Howard <howardjohn@google.com>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
Co-authored-by: Joshua Blatt <jblatt@google.com>
Co-authored-by: gargnupur <gargnupur@google.com>
Co-authored-by: Yuchen Dai <silentdai@gmail.com>
Co-authored-by: jacob-delgado <38300436+jacob-delgado@users.noreply.github.com>
Co-authored-by: Alex Nederlof <alex@nederlof.com>
brian-avery added a commit to brian-avery/istio that referenced this pull request Jan 5, 2021
* authz: fix the validation for request.headers (istio#21284)

* manual backport of 21513 (istio#21514)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

* Fix PSP sample file to allow NET_RAW. (istio#21533)

* [release-1.4] remove use_downstream_protocol for gateway (istio#21727)

* remove use_downstream_protocol for gateway

* comment

* writing

Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>

* Update dependencies (istio#21765)

* Make iptables script and output consistent with golang (istio#21871)

Co-authored-by: knrc <knrc@users.noreply.github.com>

* [release-1.4] resign certificate (istio#22131)

* resign certificate

* test

Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>

* Stop linting links of 1.4 branch (istio#22132)

This is going to continue to break as istio.io changes. We already
disabled this on 1.5/master.

* [release-1.4] Build: Honor GOBUILDFLAGS variable also in test mode (istio#22171)

We already honor it in `go build`, we should do the same
in `go test`.

Manual backport of istio#22163

* Update base image for release 1.4 (istio#22165)

* Fix GOBUILDFLAGS usage in codecov scripts (istio#22182)

This variable needs to be set before used (set -u) and must not be
quoted, otherwise it will become an empty arg for go test if it's empty.

Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>

* Update proxy to pickup fixes for ISTIO-SECURITY-2020-003. (istio#22257)

* Fix extra .Value in deployment file for stackdriver tracing vars (istio#22506)

Co-authored-by: gargnupur <gargnupur@google.com>

* Update operator SHA (istio#22523)

* clone LbEndpoint to prevent data race (istio#22023) (istio#22528)

(cherry picked from commit fdc6dd4)

Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com>

* cni: update SHA (istio#22569)

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

* Make sure to use CNI 1.4 image when running tests under CNI (istio#23035)

* Make sure to use CNI 1.4 image when running tests under CNI

* Fix lint

* [release-1.4] Update dependencies with update_deps.sh (istio#23010)

* Update deps with update_deps.sh

* Dep updates again

* [release-1.4] Run update_deps.sh (istio#23051)

* Run update_deps.sh

Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08
since update_deps.sh was not updating it.

* Run go mod tidy

* Update with another cni change (istio#23061)

* [release-1.4] Fix Gateway helm chart for helm 3 (istio#23077)

* Fix Gateway helm chart for helm 3

Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception.

By nesting the if, the problem is resolved

* Also fix the role

Co-authored-by: Alex Nederlof <alex@nederlof.com>

* Citadel completely ignores namespaces opted out. (istio#23223)

* Add Kiali fix to Helm (istio#23445)

* Update operator for istio/operator#777 (istio#23540)

* bump base (istio#23655)

* Update cni sha for release-1.4 branch (istio#24216)

* [release-1.4] Update jquery and nodejs (istio#24407)

* Add files from cherrypick

* Update yaml files to pull 1.15.1 images

Co-authored-by: Brian Avery <bavery@redhat.com>

* Update proxy sha (istio#24721)

* Bump bookinfo images

* Update vendor

Co-authored-by: Yangmin Zhu <ymzhu@google.com>
Co-authored-by: Rama Chavali <rama.rao@salesforce.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
Co-authored-by: Istio Automation <istio.testing@gmail.com>
Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>
Co-authored-by: knrc <knrc@users.noreply.github.com>
Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>
Co-authored-by: John Howard <howardjohn@google.com>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
Co-authored-by: Joshua Blatt <jblatt@google.com>
Co-authored-by: gargnupur <gargnupur@google.com>
Co-authored-by: Yuchen Dai <silentdai@gmail.com>
Co-authored-by: jacob-delgado <38300436+jacob-delgado@users.noreply.github.com>
Co-authored-by: Alex Nederlof <alex@nederlof.com>
Co-authored-by: Brian Avery <bavery@redhat.com>
Co-authored-by: Martin Ostrowski <mostrowski@google.com>
Co-authored-by: stewartbutler <stewartbutler@google.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants