-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix broken config #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix broken config #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankbu
approved these changes
Apr 5, 2017
Hmm, it looks like Jenkins is broken.
|
Jenkins job istio/presubmit passed |
zenlint
pushed a commit
to zenlint/istio
that referenced
this pull request
Aug 30, 2017
This PR simplifies some of the task by: - eliminating non-essential istioctl mixer validation step (now handled in reference docs) - eliminating the new request_size metric from the rule, as envoy doesn't currently seem to produce non-zero values for request.size - using grafana for metrics validation (instead of port-forwarding and searching through /metrics)
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Config refactoring * missing files * Remove tags from service * Fix test * fix test * fix typo in sort operator * simplify route construction * Refactor * rename * more comments * Endpoint->NetworkEndpoint, trimming comments * move design.md file to docs * nit * removing implementation specific comments * fix typo
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* support log level and scope. * apply comments. * apply comments. * format validation logs.
deva26
pushed a commit
to deva26/istio
that referenced
this pull request
Jun 24, 2020
* fixing tsbd rbac Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io> * Update clusterrole.yaml
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Jul 17, 2020
* authz: fix the validation for request.headers (istio#21284) * manual backport of 21513 (istio#21514) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * Fix PSP sample file to allow NET_RAW. (istio#21533) * [release-1.4] remove use_downstream_protocol for gateway (istio#21727) * remove use_downstream_protocol for gateway * comment * writing Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com> * Update dependencies (istio#21765) * Make iptables script and output consistent with golang (istio#21871) Co-authored-by: knrc <knrc@users.noreply.github.com> * [release-1.4] resign certificate (istio#22131) * resign certificate * test Co-authored-by: xuzhonghu <xuzhonghu@huawei.com> * Stop linting links of 1.4 branch (istio#22132) This is going to continue to break as istio.io changes. We already disabled this on 1.5/master. * [release-1.4] Build: Honor GOBUILDFLAGS variable also in test mode (istio#22171) We already honor it in `go build`, we should do the same in `go test`. Manual backport of istio#22163 * Update base image for release 1.4 (istio#22165) * Fix GOBUILDFLAGS usage in codecov scripts (istio#22182) This variable needs to be set before used (set -u) and must not be quoted, otherwise it will become an empty arg for go test if it's empty. Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> * Update proxy to pickup fixes for ISTIO-SECURITY-2020-003. (istio#22257) * Fix extra .Value in deployment file for stackdriver tracing vars (istio#22506) Co-authored-by: gargnupur <gargnupur@google.com> * Update operator SHA (istio#22523) * clone LbEndpoint to prevent data race (istio#22023) (istio#22528) (cherry picked from commit fdc6dd4) Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com> * cni: update SHA (istio#22569) Signed-off-by: Yuchen Dai <silentdai@gmail.com> * Make sure to use CNI 1.4 image when running tests under CNI (istio#23035) * Make sure to use CNI 1.4 image when running tests under CNI * Fix lint * [release-1.4] Update dependencies with update_deps.sh (istio#23010) * Update deps with update_deps.sh * Dep updates again * [release-1.4] Run update_deps.sh (istio#23051) * Run update_deps.sh Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08 since update_deps.sh was not updating it. * Run go mod tidy * Update with another cni change (istio#23061) * [release-1.4] Fix Gateway helm chart for helm 3 (istio#23077) * Fix Gateway helm chart for helm 3 Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception. By nesting the if, the problem is resolved * Also fix the role Co-authored-by: Alex Nederlof <alex@nederlof.com> Co-authored-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Rama Chavali <rama.rao@salesforce.com> Co-authored-by: Oliver Liu <yonggangl@google.com> Co-authored-by: Istio Automation <istio.testing@gmail.com> Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com> Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> Co-authored-by: knrc <knrc@users.noreply.github.com> Co-authored-by: xuzhonghu <xuzhonghu@huawei.com> Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: Eric Van Norman <ericvn@us.ibm.com> Co-authored-by: Joshua Blatt <jblatt@google.com> Co-authored-by: gargnupur <gargnupur@google.com> Co-authored-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: jacob-delgado <38300436+jacob-delgado@users.noreply.github.com> Co-authored-by: Alex Nederlof <alex@nederlof.com>
stevenctl
pushed a commit
to stevenctl/istio
that referenced
this pull request
Jun 13, 2022
* allow uproxy to send to multiple PEPs Change-Id: I7e22c44916144bcc5a9d39e236111ab546ce3663 * Gateway creates Deployment for pep Change-Id: Idae2606f28af9466cf207af263bf7ae995a12c62 * remove annotations from Deployment Change-Id: Ida86d2764e6bc53015e565d5f8d59562f59f9175 * use EDS for PEP endpoints Change-Id: I3c51240c91e4cbb17206a92fb6c0c5813a77e884 * TODO update pep deployment if yaml template changes Change-Id: If4355a6e47f00f2e61b92e0d11cd6c999ce62e9b * fix cluster type Change-Id: I0d669a960bc8851ec269facadd3073aef043a8c7 * fix UT Change-Id: Ib7ddf16b86eb6c08c5dd05d3cce67bd5f14115a8 * gen Change-Id: I96c389205d27a5ccd6fca67b43dd9b3a8737822e * fix gen Change-Id: I98b36df1271939f68f12e455c49e63c753840dc0
antonioberben
pushed a commit
to antonioberben/istio
that referenced
this pull request
Jan 29, 2024
Add custom SecretKey Option for Elasticsearch
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
…ter-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#101 is blocked on a PR in the mixer which has not gone in yet. I've extracted just the portion required to fix the breakage in the demo that I caused so this can be merged in immediately.
This change is