Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Conversation

ostromart
Copy link
Contributor

Some users are not able to move off 1.4 for some time but run into the issue during install time of error not being reported when an install timeout occurs. This backports the 1.5 behavior which outputs the name of the not-ready resource in this case.

@ostromart ostromart requested review from richardwxn and a team May 4, 2020 19:56
@istio-policy-bot
Copy link

😊 Welcome @ostromart! This is either your first contribution to the Istio operator repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 4, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2020
@istio-testing istio-testing merged commit fec36de into istio:release-1.4 May 4, 2020
ostromart added a commit to ostromart/istio that referenced this pull request May 5, 2020
istio-testing pushed a commit to istio/istio that referenced this pull request May 5, 2020
mergify bot added a commit to maistra/istio that referenced this pull request Sep 4, 2020
* authz: fix the validation for request.headers (#21284)

* manual backport of 21513 (#21514)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

* Fix PSP sample file to allow NET_RAW. (#21533)

* [release-1.4] remove use_downstream_protocol for gateway (#21727)

* remove use_downstream_protocol for gateway

* comment

* writing

Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>

* Update dependencies (#21765)

* Make iptables script and output consistent with golang (#21871)

Co-authored-by: knrc <knrc@users.noreply.github.com>

* [release-1.4] resign certificate (#22131)

* resign certificate

* test

Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>

* Stop linting links of 1.4 branch (#22132)

This is going to continue to break as istio.io changes. We already
disabled this on 1.5/master.

* [release-1.4] Build: Honor GOBUILDFLAGS variable also in test mode (#22171)

We already honor it in `go build`, we should do the same
in `go test`.

Manual backport of istio/istio#22163

* Update base image for release 1.4 (#22165)

* Fix GOBUILDFLAGS usage in codecov scripts (#22182)

This variable needs to be set before used (set -u) and must not be
quoted, otherwise it will become an empty arg for go test if it's empty.

Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>

* Update proxy to pickup fixes for ISTIO-SECURITY-2020-003. (#22257)

* Fix extra .Value in deployment file for stackdriver tracing vars (#22506)

Co-authored-by: gargnupur <gargnupur@google.com>

* Update operator SHA (#22523)

* clone LbEndpoint to prevent data race (#22023) (#22528)

(cherry picked from commit fdc6dd4)

Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com>

* cni: update SHA (#22569)

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

* Make sure to use CNI 1.4 image when running tests under CNI (#23035)

* Make sure to use CNI 1.4 image when running tests under CNI

* Fix lint

* [release-1.4] Update dependencies with update_deps.sh (#23010)

* Update deps with update_deps.sh

* Dep updates again

* [release-1.4] Run update_deps.sh (#23051)

* Run update_deps.sh

Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08
since update_deps.sh was not updating it.

* Run go mod tidy

* Update with another cni change (#23061)

* [release-1.4] Fix Gateway helm chart for helm 3 (#23077)

* Fix Gateway helm chart for helm 3

Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception.

By nesting the if, the problem is resolved

* Also fix the role

Co-authored-by: Alex Nederlof <alex@nederlof.com>

* Citadel completely ignores namespaces opted out. (#23223)

* Add Kiali fix to Helm (#23445)

* Update operator for istio/operator#777 (#23540)

* bump base (#23655)

* Update cni sha for release-1.4 branch (#24216)

* [release-1.4] Update jquery and nodejs (#24407)

* Add files from cherrypick

* Update yaml files to pull 1.15.1 images

Co-authored-by: Brian Avery <bavery@redhat.com>

* Update proxy sha (#24721)

* Bump bookinfo images

* Update vendor

Co-authored-by: Yangmin Zhu <ymzhu@google.com>
Co-authored-by: Rama Chavali <rama.rao@salesforce.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
Co-authored-by: Istio Automation <istio.testing@gmail.com>
Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>
Co-authored-by: knrc <knrc@users.noreply.github.com>
Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>
Co-authored-by: John Howard <howardjohn@google.com>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
Co-authored-by: Joshua Blatt <jblatt@google.com>
Co-authored-by: gargnupur <gargnupur@google.com>
Co-authored-by: Yuchen Dai <silentdai@gmail.com>
Co-authored-by: jacob-delgado <38300436+jacob-delgado@users.noreply.github.com>
Co-authored-by: Alex Nederlof <alex@nederlof.com>
Co-authored-by: Brian Avery <bavery@redhat.com>
Co-authored-by: Martin Ostrowski <mostrowski@google.com>
Co-authored-by: stewartbutler <stewartbutler@google.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants