[1.4] clone LbEndpoint to prevent data race (#22023) #22528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fdc6dd4)
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
@howardjohn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jwendell
approved these changes
Mar 26, 2020
|
🎊 Thanks @howardjohn ! |
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Jul 17, 2020
* authz: fix the validation for request.headers (istio#21284) * manual backport of 21513 (istio#21514) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * Fix PSP sample file to allow NET_RAW. (istio#21533) * [release-1.4] remove use_downstream_protocol for gateway (istio#21727) * remove use_downstream_protocol for gateway * comment * writing Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com> * Update dependencies (istio#21765) * Make iptables script and output consistent with golang (istio#21871) Co-authored-by: knrc <knrc@users.noreply.github.com> * [release-1.4] resign certificate (istio#22131) * resign certificate * test Co-authored-by: xuzhonghu <xuzhonghu@huawei.com> * Stop linting links of 1.4 branch (istio#22132) This is going to continue to break as istio.io changes. We already disabled this on 1.5/master. * [release-1.4] Build: Honor GOBUILDFLAGS variable also in test mode (istio#22171) We already honor it in `go build`, we should do the same in `go test`. Manual backport of istio#22163 * Update base image for release 1.4 (istio#22165) * Fix GOBUILDFLAGS usage in codecov scripts (istio#22182) This variable needs to be set before used (set -u) and must not be quoted, otherwise it will become an empty arg for go test if it's empty. Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> * Update proxy to pickup fixes for ISTIO-SECURITY-2020-003. (istio#22257) * Fix extra .Value in deployment file for stackdriver tracing vars (istio#22506) Co-authored-by: gargnupur <gargnupur@google.com> * Update operator SHA (istio#22523) * clone LbEndpoint to prevent data race (istio#22023) (istio#22528) (cherry picked from commit fdc6dd4) Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com> * cni: update SHA (istio#22569) Signed-off-by: Yuchen Dai <silentdai@gmail.com> * Make sure to use CNI 1.4 image when running tests under CNI (istio#23035) * Make sure to use CNI 1.4 image when running tests under CNI * Fix lint * [release-1.4] Update dependencies with update_deps.sh (istio#23010) * Update deps with update_deps.sh * Dep updates again * [release-1.4] Run update_deps.sh (istio#23051) * Run update_deps.sh Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08 since update_deps.sh was not updating it. * Run go mod tidy * Update with another cni change (istio#23061) * [release-1.4] Fix Gateway helm chart for helm 3 (istio#23077) * Fix Gateway helm chart for helm 3 Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception. By nesting the if, the problem is resolved * Also fix the role Co-authored-by: Alex Nederlof <alex@nederlof.com> Co-authored-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Rama Chavali <rama.rao@salesforce.com> Co-authored-by: Oliver Liu <yonggangl@google.com> Co-authored-by: Istio Automation <istio.testing@gmail.com> Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com> Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> Co-authored-by: knrc <knrc@users.noreply.github.com> Co-authored-by: xuzhonghu <xuzhonghu@huawei.com> Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: Eric Van Norman <ericvn@us.ibm.com> Co-authored-by: Joshua Blatt <jblatt@google.com> Co-authored-by: gargnupur <gargnupur@google.com> Co-authored-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: jacob-delgado <38300436+jacob-delgado@users.noreply.github.com> Co-authored-by: Alex Nederlof <alex@nederlof.com>
brian-avery
added a commit
to brian-avery/istio
that referenced
this pull request
Jan 5, 2021
* authz: fix the validation for request.headers (istio#21284) * manual backport of 21513 (istio#21514) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * Fix PSP sample file to allow NET_RAW. (istio#21533) * [release-1.4] remove use_downstream_protocol for gateway (istio#21727) * remove use_downstream_protocol for gateway * comment * writing Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com> * Update dependencies (istio#21765) * Make iptables script and output consistent with golang (istio#21871) Co-authored-by: knrc <knrc@users.noreply.github.com> * [release-1.4] resign certificate (istio#22131) * resign certificate * test Co-authored-by: xuzhonghu <xuzhonghu@huawei.com> * Stop linting links of 1.4 branch (istio#22132) This is going to continue to break as istio.io changes. We already disabled this on 1.5/master. * [release-1.4] Build: Honor GOBUILDFLAGS variable also in test mode (istio#22171) We already honor it in `go build`, we should do the same in `go test`. Manual backport of istio#22163 * Update base image for release 1.4 (istio#22165) * Fix GOBUILDFLAGS usage in codecov scripts (istio#22182) This variable needs to be set before used (set -u) and must not be quoted, otherwise it will become an empty arg for go test if it's empty. Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> * Update proxy to pickup fixes for ISTIO-SECURITY-2020-003. (istio#22257) * Fix extra .Value in deployment file for stackdriver tracing vars (istio#22506) Co-authored-by: gargnupur <gargnupur@google.com> * Update operator SHA (istio#22523) * clone LbEndpoint to prevent data race (istio#22023) (istio#22528) (cherry picked from commit fdc6dd4) Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com> * cni: update SHA (istio#22569) Signed-off-by: Yuchen Dai <silentdai@gmail.com> * Make sure to use CNI 1.4 image when running tests under CNI (istio#23035) * Make sure to use CNI 1.4 image when running tests under CNI * Fix lint * [release-1.4] Update dependencies with update_deps.sh (istio#23010) * Update deps with update_deps.sh * Dep updates again * [release-1.4] Run update_deps.sh (istio#23051) * Run update_deps.sh Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08 since update_deps.sh was not updating it. * Run go mod tidy * Update with another cni change (istio#23061) * [release-1.4] Fix Gateway helm chart for helm 3 (istio#23077) * Fix Gateway helm chart for helm 3 Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception. By nesting the if, the problem is resolved * Also fix the role Co-authored-by: Alex Nederlof <alex@nederlof.com> * Citadel completely ignores namespaces opted out. (istio#23223) * Add Kiali fix to Helm (istio#23445) * Update operator for istio/operator#777 (istio#23540) * bump base (istio#23655) * Update cni sha for release-1.4 branch (istio#24216) * [release-1.4] Update jquery and nodejs (istio#24407) * Add files from cherrypick * Update yaml files to pull 1.15.1 images Co-authored-by: Brian Avery <bavery@redhat.com> * Update proxy sha (istio#24721) * Bump bookinfo images * Update vendor Co-authored-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Rama Chavali <rama.rao@salesforce.com> Co-authored-by: Oliver Liu <yonggangl@google.com> Co-authored-by: Istio Automation <istio.testing@gmail.com> Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com> Co-authored-by: knrc <knrc@users.noreply.github.com> Co-authored-by: xuzhonghu <xuzhonghu@huawei.com> Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: Eric Van Norman <ericvn@us.ibm.com> Co-authored-by: Joshua Blatt <jblatt@google.com> Co-authored-by: gargnupur <gargnupur@google.com> Co-authored-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: jacob-delgado <38300436+jacob-delgado@users.noreply.github.com> Co-authored-by: Alex Nederlof <alex@nederlof.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Martin Ostrowski <mostrowski@google.com> Co-authored-by: stewartbutler <stewartbutler@google.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit fdc6dd4)
#22023