Add x-goog-user-proj header for sts credential #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
mandarjog
reviewed
Feb 17, 2020
mandarjog
reviewed
Feb 17, 2020
| GoogleUserProjHeaderInterceptor(const std::string& project_id) : project_id_(project_id) {} | ||
|
|
||
| virtual void Intercept(grpc::experimental::InterceptorBatchMethods* methods) { | ||
| if (methods->QueryInterceptionHookPoint( |
There was a problem hiding this comment.
@g-easy does this look ok?
It is being directly pushed into an intermediary version of envoy in istio.
There was a problem hiding this comment.
This should not be needed in envoy master after grpc/grpc#21225 is resolved.
There was a problem hiding this comment.
This seems reasonable to me but I haven't dealt with interceptors before.
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
|
Xref: envoyproxy/envoy-wasm#414 |
|
Let me separate the wasm change into a upstream PR. |
|
@bianpengyuan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bianpengyuan
added a commit
to bianpengyuan/envoy
that referenced
this pull request
Feb 21, 2020
* add x-google-user-proj header Signed-off-by: Pengyuan Bian <bianpengyuan@google.com> * clean up log Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
istio-testing
pushed a commit
that referenced
this pull request
Feb 23, 2020
* fix tracer ssl credential (#151) Signed-off-by: Pengyuan Bian <bianpengyuan@google.com> * Add x-goog-user-proj header for sts credential (#152) * add x-google-user-proj header Signed-off-by: Pengyuan Bian <bianpengyuan@google.com> * clean up log Signed-off-by: Pengyuan Bian <bianpengyuan@google.com> * fix opencensus tracer (#155) Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
duderino
added a commit
to duderino/envoy
that referenced
this pull request
Mar 3, 2020
This reverts commit 37dbbd4.
istio-testing
pushed a commit
that referenced
this pull request
Mar 4, 2020
…fixes. (#180) * Revert "fix opencensus tracer (#155)" This reverts commit 063eeb9. * Revert "Add x-goog-user-proj header for sts credential (#152)" This reverts commit 37dbbd4. * Revert "Update GrpcService to add StsService. (envoyproxy#411)" This reverts commit ab59731. * Revert "fix tracer ssl credential (#151)" This reverts commit 02901d0. * Revert "remove url validation as it is not implemented" This reverts commit 3eb2101. * Revert "Use gRPC Security Token Service (STS) to get call credentials (envoyproxy#9101)" This reverts commit ec6b907. * Revert "[release-1.4] Use sts for call credential when STS_PORT is provided in node metadata #144 (#148)" This reverts commit 7081e43. * Revert "Upgrade gRPC to 1.25 which has gRPC STS feature (#145)" This reverts commit 03ecfad. * ci: mark //test/integration:protocol_integration_test as flaky. (#162) Backport envoyproxy/envoy-wasm#422 and its prerequisite (envoyproxy#10009). * Plumb the flaky flag from envoy_cc_test to the native.cc_test (envoyproxy#10009) Signed-off-by: Yan Avlasov <yavlasov@google.com> * ci: mark //test/integration:protocol_integration_test as flaky. (envoyproxy#422) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Remove wasm filter stress test Signed-off-by: gargnupur <gargnupur@google.com> * Remove wasm stress test framework Signed-off-by: gargnupur <gargnupur@google.com> Co-authored-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: Nupur Garg <37600866+gargnupur@users.noreply.github.com>
Miss-you
pushed a commit
to Miss-you/envoy
that referenced
this pull request
Nov 17, 2020
zh-translation: docs/root/intro/arch_overview/other_features/other_fe…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pengyuan Bian bianpengyuan@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]