Skip to content

Conversation

JimmyCYJ
Copy link
Member

@JimmyCYJ JimmyCYJ commented Nov 21, 2019

Add a new field sts_service into GoogleGrpc call credential options which support Envoy to exchange token. See grpc/grpc#19032 and grpc/grpc#19587.

Signed-off-by: JimmyCYJ jimmychen.0102@gmail.com

Risk Level: Low
Testing: Unit test

Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #9101 was opened by JimmyCYJ.

see: more, trace.

@JimmyCYJ
Copy link
Member Author

/cc @htuch @lizan

@JimmyCYJ JimmyCYJ changed the title Sts call credential Use gRPC Security Token Service (STS) to get call credentials Nov 21, 2019
@stale
Copy link

stale bot commented Nov 30, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added stale stalebot believes this issue/PR has not been touched recently and removed stale stalebot believes this issue/PR has not been touched recently labels Nov 30, 2019
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
…dential

Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Copy link
Member Author

@JimmyCYJ JimmyCYJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htuch Please take a look. Thanks!

Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
@lizan
Copy link
Member

lizan commented Dec 5, 2019

/azp run envoy-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@repokitteh-read-only repokitteh-read-only bot removed the api label Dec 6, 2019
@htuch htuch merged commit 46e65a4 into envoyproxy:master Dec 6, 2019
@JimmyCYJ JimmyCYJ deleted the sts-call-credential branch December 6, 2019 17:39
JimmyCYJ added a commit to istio/envoy that referenced this pull request Feb 13, 2020
…roxy#9101)

Add a new field sts_service into GoogleGrpc call credential options which support Envoy to exchange token. See grpc/grpc#19032 and grpc/grpc#19587.

Signed-off-by: JimmyCYJ jimmychen.0102@gmail.com

Risk Level: Low
Testing: Unit test

Signed-off-by: Jimmy Chen <jimmychen.0102@gmail.com>
duderino added a commit to duderino/envoy that referenced this pull request Mar 3, 2020
istio-testing pushed a commit to istio/envoy that referenced this pull request Mar 4, 2020
…fixes. (#180)

* Revert "fix opencensus tracer (#155)"

This reverts commit 063eeb9.

* Revert "Add x-goog-user-proj header for sts credential (#152)"

This reverts commit 37dbbd4.

* Revert "Update GrpcService to add StsService. (envoyproxy#411)"

This reverts commit ab59731.

* Revert "fix tracer ssl credential (#151)"

This reverts commit 02901d0.

* Revert "remove url validation as it is not implemented"

This reverts commit 3eb2101.

* Revert "Use gRPC Security Token Service (STS) to get call credentials (envoyproxy#9101)"

This reverts commit ec6b907.

* Revert "[release-1.4] Use sts for call credential when STS_PORT is provided in node metadata #144 (#148)"

This reverts commit 7081e43.

* Revert "Upgrade gRPC to 1.25 which has gRPC STS feature (#145)"

This reverts commit 03ecfad.

* ci: mark //test/integration:protocol_integration_test as flaky. (#162)

Backport envoyproxy/envoy-wasm#422 and its prerequisite (envoyproxy#10009).

* Plumb the flaky flag from envoy_cc_test to the native.cc_test (envoyproxy#10009)

Signed-off-by: Yan Avlasov <yavlasov@google.com>

* ci: mark //test/integration:protocol_integration_test as flaky. (envoyproxy#422)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* Remove wasm filter  stress  test

Signed-off-by: gargnupur <gargnupur@google.com>

* Remove wasm stress  test framework

Signed-off-by: gargnupur <gargnupur@google.com>

Co-authored-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Nupur Garg <37600866+gargnupur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants