-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Multi-mission radioisotope thermoelectric generator #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-mission radioisotope thermoelectric generator #990
Conversation
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
Please fix the linting issue(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder name has a misspelling that should be corrected.
knowledge/science/astronomy_tech/radioisotope_thermo_generator/
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the folder name to properly spell "thermo" regarding: af9eb46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Your second commit is lacking the necessary Signed-off-by and the PR is failing the DCO check. Please fix.
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
knowledge/science/astronomy_tech/radioisotope_thermo_generator/qna.yml
Outdated
Show resolved
Hide resolved
56ab90d
to
24a6585
Compare
I think that I have the changes taken care of now regarding signing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple issues to resolve
knowledge/science/astronomy_tech/radioisotope_thermo_generator/.gitignore
Outdated
Show resolved
Hide resolved
knowledge/science/astronomy_tech/radioisotope_thermo_generator/qna.yml
Outdated
Show resolved
Hide resolved
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
c58d69b
to
57d5b95
Compare
Please fix the linting issue(s). |
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
Linting issue should be fixed now. I broke up my answers into multiple lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file and directory is needs to be removed from this PR.
And if you can squash this down to one commit please. |
22ad67f
to
ec4d33f
Compare
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
@instructlab-bot precheck |
Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 295. The results will be presented below in the pull request status box. This may take several minutes... |
Results for job ID: 295 using the model merlinite-7b! Results can be found here. |
@instructlab generate |
@instructlab-bot generate |
Beep, boop 🤖, Generating test data for your PR with the job type: sdg-svc. Your Job ID is 296. The results will be presented below in the pull request status box. This may take several minutes... |
Signed-off-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com> Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
ec4d33f
to
2c9a6ca
Compare
Results for job ID: 296 using the model sdg service backend! Results can be found here. |
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024. This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990 #1019 #1013 #1038 #1043 #1046 #1051 Signed-off-by: JJ Asghar <awesome@ibm.com> Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com> Co-authored-by: vamsibtech <vamsibtech@yahoo.com> Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com> Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu> Co-authored-by: ssheth1 <seth.samir@gmail.com> Co-authored-by: pluk813 <Phillip_luk@yahoo.com> Co-authored-by: frankfnord <frankfnord@users.noreply.github.com> Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com> Co-authored-by: ajayka0989 <kumatswag@gmail.com> Co-authored-by: David Jaros <jdavid.cz@gmail.com> Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com> Co-authored-by: BJ Hargrave <hargrave@us.ibm.com> Co-authored-by: Deni (s55db) <b4d@sablun.org> Co-authored-by: b4d <b4d@sablun.org> Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com> Co-authored-by: jenjetemail <jenjetemail@gmail.com> Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com> Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com> Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
Closing due to combined PR here: #1142 |
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024. This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990 #1019 #1013 #1038 #1043 #1046 #1051 Signed-off-by: JJ Asghar <awesome@ibm.com> Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com> Co-authored-by: vamsibtech <vamsibtech@yahoo.com> Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com> Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu> Co-authored-by: ssheth1 <seth.samir@gmail.com> Co-authored-by: pluk813 <Phillip_luk@yahoo.com> Co-authored-by: frankfnord <frankfnord@users.noreply.github.com> Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com> Co-authored-by: ajayka0989 <kumatswag@gmail.com> Co-authored-by: David Jaros <jdavid.cz@gmail.com> Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com> Co-authored-by: BJ Hargrave <hargrave@us.ibm.com> Co-authored-by: Deni (s55db) <b4d@sablun.org> Co-authored-by: b4d <b4d@sablun.org> Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com> Co-authored-by: jenjetemail <jenjetemail@gmail.com> Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com> Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com> Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024. This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990 #1019 #1013 #1038 #1043 #1046 #1051 Signed-off-by: JJ Asghar <awesome@ibm.com> Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com> Co-authored-by: vamsibtech <vamsibtech@yahoo.com> Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com> Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu> Co-authored-by: ssheth1 <seth.samir@gmail.com> Co-authored-by: pluk813 <Phillip_luk@yahoo.com> Co-authored-by: frankfnord <frankfnord@users.noreply.github.com> Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com> Co-authored-by: ajayka0989 <kumatswag@gmail.com> Co-authored-by: David Jaros <jdavid.cz@gmail.com> Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com> Co-authored-by: BJ Hargrave <hargrave@us.ibm.com> Co-authored-by: Deni (s55db) <b4d@sablun.org> Co-authored-by: b4d <b4d@sablun.org> Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com> Co-authored-by: jenjetemail <jenjetemail@gmail.com> Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com> Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com> Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy
Input given at the prompt
Response from the original model
Response from the fine-tuned model
Contribution checklist
ilab generate
ilab generate
qna.yaml
file contains at least 5seed_examples
qna.yaml
file was linted and prettified (yaml-validator can do both)attribution.txt
file in the same folder as theqna.yaml
file