Skip to content

Conversation

frankfnord
Copy link

@frankfnord frankfnord commented May 8, 2024

#839

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

  • ...
  • ...
  • ...

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • All commits are signed off (DCO)
  • The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • Content does not include PII or otherwise sensitive or confidential information
  • Content does not include anything documented in the project's Avoid these Topics guidelines

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels May 8, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@bjhargrave bjhargrave changed the title Multi-mission radioisotope thermoelectric generator Multi-mission radioisotope thermoelectric generator knowledge May 9, 2024
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder name has a misspelling that should be corrected.

knowledge/science/astronomy_tech/radioisotope_thermo_generator

@bjhargrave bjhargrave added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels May 9, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 22, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@frankfnord
Copy link
Author

changed the amount of chars. should fix the linting issue.

@frankfnord frankfnord requested a review from bjhargrave May 22, 2024 13:31
@bjhargrave
Copy link
Contributor

Please amend your last commit to include the Signed-off-by. Thanks.

@frankfnord
Copy link
Author

included the Signed-off-by.

@bjhargrave
Copy link
Contributor

included the Signed-off-by.

Hi, you have 8 commits in this PR and 3 are missing the necessary Signed-off-by. All commits need it. So you may want to squash your commits into a single commit that has the proper Signed-off-by. Thanks.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these issues that we have found.

@jjasghar
Copy link
Member

Also please fix the DCO issue(s).

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 22, 2024
jjasghar pushed a commit that referenced this pull request May 23, 2024
Renaming thermo Dir related to #955 
/cc @jjasghar 
Related to triage call.

Signed-off-by: James Labocki <jameslabocki@gmail.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Co-authored-by: James Labocki <jameslabocki@gmail.com>
@jjasghar
Copy link
Member

Please rebase of our changes.

…tlab#955

Squashed commit of the following:

commit 40fdfea79783c36c4d349ba187ab6855afda0aab
Author: Frank Korrell <frank@korrell.net>
Date:   Fri May 24 10:57:43 2024 +0200

    fix yammlint issues

commit 16633563c7eae01b8bae185a36faf219a468b092
Author: Frank Korrell <frank@korrell.net>
Date:   Fri May 24 10:32:01 2024 +0200

    fix username and remove .gitignore

commit 5fc2a47
Merge: 4ea599f 94f7dd4
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 16:12:47 2024 +0000

    Merge remote-tracking branch 'refs/remotes/origin/patch-1' into patch-1

commit 4ea599f
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 16:10:02 2024 +0000

    squashed commits

    Signed-off-by: frankfnord <frankfnord@users.noreply.github.com>

commit 94f7dd4
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 13:56:57 2024 +0000

    change wording.

    Signed-off-by: frankfnord <frankfnord@users.noreply.github.com>

commit b17f1dd
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 13:54:23 2024 +0000

    remove blanks

commit 684eb7a
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 13:48:01 2024 +0000

    add created_by information

commit 4d79a02
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 13:29:54 2024 +0000

    renamed folder.

commit e96fb21
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 22 13:34:44 2024 +0200

    Update qna.yaml and fix linting

    Signed-off-by: frankfnord <frankfnord@users.noreply.github.com>

commit ea8a08e
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 8 15:38:56 2024 -0600

    Add files via upload

    instructlab#839

    Signed-off-by: frankfnord <frankfnord@users.noreply.github.com>

commit 9c63354
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 8 15:34:46 2024 -0600

    Add files via upload

    instructlab#839

    Signed-off-by: frankfnord <frankfnord@users.noreply.github.com>

commit 042c43b
Author: frankfnord <frankfnord@users.noreply.github.com>
Date:   Wed May 8 15:28:50 2024 -0600

    Create qna.yaml

    Signed-off-by: frankfnord <frankfnord@users.noreply.github.com>

Signed-off-by: Frank Korrell <frank@korrell.net>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 24, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@frankfnord frankfnord requested a review from jjasghar May 24, 2024 09:21
@frankfnord
Copy link
Author

hopefully fixed now. sorry for the noise 🙈

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linting listed here: https://github.com/instructlab/taxonomy/pull/955/files and rebase off of main.

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 28, 2024
jjasghar added a commit that referenced this pull request May 30, 2024
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024.

This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990
 #1019 #1013 #1038 #1043 #1046 #1051

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com>
Co-authored-by: vamsibtech <vamsibtech@yahoo.com>
Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com>
Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu>
Co-authored-by: ssheth1 <seth.samir@gmail.com>
Co-authored-by: pluk813 <Phillip_luk@yahoo.com>
Co-authored-by: frankfnord <frankfnord@users.noreply.github.com>
Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com>
Co-authored-by: ajayka0989 <kumatswag@gmail.com>
Co-authored-by: David Jaros <jdavid.cz@gmail.com>
Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com>
Co-authored-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: Deni (s55db) <b4d@sablun.org>
Co-authored-by: b4d <b4d@sablun.org>
Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com>
Co-authored-by: jenjetemail <jenjetemail@gmail.com>
Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com>
Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com>
Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
@jjasghar
Copy link
Member

Closing due to combined PR here: #1142

@jjasghar jjasghar closed this May 30, 2024
jjasghar added a commit that referenced this pull request May 30, 2024
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024.

This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990
 #1019 #1013 #1038 #1043 #1046 #1051

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com>
Co-authored-by: vamsibtech <vamsibtech@yahoo.com>
Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com>
Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu>
Co-authored-by: ssheth1 <seth.samir@gmail.com>
Co-authored-by: pluk813 <Phillip_luk@yahoo.com>
Co-authored-by: frankfnord <frankfnord@users.noreply.github.com>
Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com>
Co-authored-by: ajayka0989 <kumatswag@gmail.com>
Co-authored-by: David Jaros <jdavid.cz@gmail.com>
Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com>
Co-authored-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: Deni (s55db) <b4d@sablun.org>
Co-authored-by: b4d <b4d@sablun.org>
Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com>
Co-authored-by: jenjetemail <jenjetemail@gmail.com>
Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com>
Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com>
Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
jjasghar added a commit that referenced this pull request May 30, 2024
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024.

This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990
 #1019 #1013 #1038 #1043 #1046 #1051

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com>
Co-authored-by: vamsibtech <vamsibtech@yahoo.com>
Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com>
Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu>
Co-authored-by: ssheth1 <seth.samir@gmail.com>
Co-authored-by: pluk813 <Phillip_luk@yahoo.com>
Co-authored-by: frankfnord <frankfnord@users.noreply.github.com>
Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com>
Co-authored-by: ajayka0989 <kumatswag@gmail.com>
Co-authored-by: David Jaros <jdavid.cz@gmail.com>
Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com>
Co-authored-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: Deni (s55db) <b4d@sablun.org>
Co-authored-by: b4d <b4d@sablun.org>
Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com>
Co-authored-by: jenjetemail <jenjetemail@gmail.com>
Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com>
Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com>
Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
@frankfnord frankfnord deleted the patch-1 branch May 31, 2024 06:07
jjasghar pushed a commit to luke-inglis/taxonomy that referenced this pull request Jun 7, 2024
…) (instructlab#1119)

Renaming thermo Dir related to instructlab#955 
/cc @jjasghar 
Related to triage call.

Signed-off-by: James Labocki <jameslabocki@gmail.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Co-authored-by: James Labocki <jameslabocki@gmail.com>
jjasghar pushed a commit to acidonper/taxonomy that referenced this pull request Jun 10, 2024
…) (instructlab#1119)

Renaming thermo Dir related to instructlab#955 
/cc @jjasghar 
Related to triage call.

Signed-off-by: James Labocki <jameslabocki@gmail.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Co-authored-by: James Labocki <jameslabocki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants