Skip to content

Conversation

b4d
Copy link

@b4d b4d commented May 9, 2024

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels May 9, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar
Copy link
Member

jjasghar commented May 9, 2024

Please fix the linting issue(s).

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels May 9, 2024
@bjhargrave bjhargrave changed the title Add files via upload Multi-mission radioisotope thermoelectric generator knowledge May 9, 2024
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder name has a misspelling that should be corrected.

knowledge/science/astronomy_tech/radioisotope_thermo_generator/

@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 11, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar
Copy link
Member

Please fix the linting issue(s).

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 13, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 14, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve this issue.

@jjasghar
Copy link
Member

Please delete the .gitignore and fix the DCO issue too.

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 14, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 24, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

b4d and others added 10 commits May 24, 2024 12:38
Signed-off-by: Deni (s55db) <b4d@sablun.org>
Signed-off-by: b4d <b4d@sablun.org>
Signed-off-by: Deni (s55db) <b4d@sablun.org>
Signed-off-by: b4d <b4d@sablun.org>
Adding workflow to trigger CoC analysis, post `Lint` workflow is
successful.

CoC analysis validates the contribution yml files against the following
areas:

- Privacy (Personal Identifiable Information)
- HAP (Hate, Abuse, Profanity)
- Inappropriate Content (Adult, Illegal, Gambling)
- Regulated Industries (Medical, Financial)

Signed-off-by: Nitin Ramchandani <nitin.ramchandani@ibm.com>
Signed-off-by: b4d <b4d@sablun.org>
Set some defaults and use github.events context instead of bash
commands.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Signed-off-by: b4d <b4d@sablun.org>
This will allow us to see which PR a specific workflow run was for.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Signed-off-by: b4d <b4d@sablun.org>
We also only run the workflow if there is a PR associated.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Signed-off-by: b4d <b4d@sablun.org>
Signed-off-by: Deni (s55db) <b4d@sablun.org>
Signed-off-by: b4d <b4d@sablun.org>
Signed-off-by: b4d <b4d@sablun.org>
…/.gitignore

Deleted .gitignore

Signed-off-by: Deni (s55db) <b4d@sablun.org>
Signed-off-by: b4d <b4d@sablun.org>
Signed-off-by: Deni (s55db) <b4d@sablun.org>
Signed-off-by: b4d <b4d@sablun.org>
@github-actions github-actions bot added the ci label May 24, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@b4d b4d requested review from bjhargrave and jjasghar May 25, 2024 10:21
@jjasghar jjasghar removed triage-needed (Auto labeled) skill is ready to be triaged ci labels May 28, 2024
@jjasghar
Copy link
Member

Please rebase off of main, and only commit your attribution.txt and qna.yaml.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look above about the rebase.

jjasghar added a commit that referenced this pull request May 30, 2024
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024.

This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990
 #1019 #1013 #1038 #1043 #1046 #1051

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com>
Co-authored-by: vamsibtech <vamsibtech@yahoo.com>
Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com>
Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu>
Co-authored-by: ssheth1 <seth.samir@gmail.com>
Co-authored-by: pluk813 <Phillip_luk@yahoo.com>
Co-authored-by: frankfnord <frankfnord@users.noreply.github.com>
Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com>
Co-authored-by: ajayka0989 <kumatswag@gmail.com>
Co-authored-by: David Jaros <jdavid.cz@gmail.com>
Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com>
Co-authored-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: Deni (s55db) <b4d@sablun.org>
Co-authored-by: b4d <b4d@sablun.org>
Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com>
Co-authored-by: jenjetemail <jenjetemail@gmail.com>
Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com>
Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com>
Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
@jjasghar
Copy link
Member

Closing due to combined PR here: #1142

@jjasghar jjasghar closed this May 30, 2024
jjasghar added a commit that referenced this pull request May 30, 2024
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024.

This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990
 #1019 #1013 #1038 #1043 #1046 #1051

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com>
Co-authored-by: vamsibtech <vamsibtech@yahoo.com>
Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com>
Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu>
Co-authored-by: ssheth1 <seth.samir@gmail.com>
Co-authored-by: pluk813 <Phillip_luk@yahoo.com>
Co-authored-by: frankfnord <frankfnord@users.noreply.github.com>
Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com>
Co-authored-by: ajayka0989 <kumatswag@gmail.com>
Co-authored-by: David Jaros <jdavid.cz@gmail.com>
Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com>
Co-authored-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: Deni (s55db) <b4d@sablun.org>
Co-authored-by: b4d <b4d@sablun.org>
Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com>
Co-authored-by: jenjetemail <jenjetemail@gmail.com>
Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com>
Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com>
Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
jjasghar added a commit that referenced this pull request May 30, 2024
This is the combined radiosotope thermoelectric generatoraPRs from Red Hat Summit 2024.

This superseeds #932 #926 #923 #921 #945 #951 #955 #976 #977 #986 #990
 #1019 #1013 #1038 #1043 #1046 #1051

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Ivan Tarin <ivan0tarin@gmail.com>
Co-authored-by: vamsibtech <vamsibtech@yahoo.com>
Co-authored-by: Andrew Watson <146371748+awatsoncc@users.noreply.github.com>
Co-authored-by: dcheripk <dcheripk@andrew.cmu.edu>
Co-authored-by: ssheth1 <seth.samir@gmail.com>
Co-authored-by: pluk813 <Phillip_luk@yahoo.com>
Co-authored-by: frankfnord <frankfnord@users.noreply.github.com>
Co-authored-by: AdityaChinni10 <honey10aditya@gmail.com>
Co-authored-by: ajayka0989 <kumatswag@gmail.com>
Co-authored-by: David Jaros <jdavid.cz@gmail.com>
Co-authored-by: Ian Wright -- Mainline Information Systems <108477581+mainline-automation@users.noreply.github.com>
Co-authored-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: Deni (s55db) <b4d@sablun.org>
Co-authored-by: b4d <b4d@sablun.org>
Co-authored-by: siti5ruz <131858182+siti5ruz@users.noreply.github.com>
Co-authored-by: jenjetemail <jenjetemail@gmail.com>
Co-authored-by: Joseph Tejal <joseph_tejal@yahoo.com>
Co-authored-by: labhassu <62534053+labhassu@users.noreply.github.com>
Co-authored-by: Joe Seegmiller <joeseegmiller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants