Advice against running "generate" and "chat" in parallel #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make users aware of possible segfaults (#346). Place the notice at the beginning of the respective section. Also move the existing notice on how long "lab generate" takes next to it. Signed-off-by: Václav Kadlčík <vkadlcik@redhat.com>
Signed-off-by: vkadlcik <54436400+vkadlcik@users.noreply.github.com>
russellb
requested changes
Apr 1, 2024
Signed-off-by: vkadlcik <54436400+vkadlcik@users.noreply.github.com>
russellb
requested changes
Apr 3, 2024
Make users aware of possible segfaults, just like when "generate" and "chat" run in parallel (#346). Signed-off-by: vkadlcik <54436400+vkadlcik@users.noreply.github.com>
Ah, right, when originally mentioned I thought it wasn't meant for me. Sorry, my mistake. |
|
Do we still need this if #804 is in place? In my mind: Argument for calling this out in the doc: Doesn't hurt to have it. Argument against called this out in the doc: https://github.com/instruct-lab/cli/pull/741/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R233 may message out to readers that it's the |
Merged
jgato
pushed a commit
to jgato/instructlab
that referenced
this pull request
Jun 21, 2024
I propose dropping the CODEOWNERS file. The use of CODEOWNERS prevents the default notifications setting of "Participating and @mentioned" from working. If you are in the CODEOWNERS, you get added to every PR and will get all notifications accordingly. This is pretty painful on a busy repo. If a maintainer desires that level of email notifications, they can change their setting to "All Activity" for the repository. CODEOWNERS is also not acting as access control to the repository. That access is managed via github teams, and those teams are granted different levels of access to the respository. In summary, by not using a top-level entry like this, I feel we give people more control over their notifications while not losing any level of access controls on the repo. It allows people to stick to a workflow that best works for them. Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Russell Bryant <rbryant@redhat.com>
jgato
pushed a commit
to jgato/instructlab
that referenced
this pull request
Jun 21, 2024
instructlab#741 deleted the contents of the file but not the file itself. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make users aware of possible segfaults (#346).
Place the notice at the beginning of the respective section. Also move the existing notice on how long "lab generate" takes next to it.
(This PR replaces PR #508 which I dropped due to missing sign-off and merge conflicts)