Advice against running "generate" and "chat" in parallel #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make users aware of possible segfaults (#346). Place the notice at the beginning of the respective section. Also move the existing notice on how long "lab generate" takes next to it.
kelbrown20
reviewed
Mar 11, 2024
Co-authored-by: Kelly Brown <86735520+kelbrown20@users.noreply.github.com> Signed-off-by: vkadlcik <54436400+vkadlcik@users.noreply.github.com>
|
Thanks @kelbrown20, makes sense, upgraded to IMPORTANT. Regarding the policy, I as user would definitely want to know more when reading the warning but I admit I may not be a typical user. I don't insist on referring the issue. The advice itself should be published though, before more people waste plenty of electricity and get a little upset :-) |
xukai92
approved these changes
Mar 19, 2024
|
DCO fails and there are merge conflicts. can you please fix? |
Signed-off-by: vkadlcik <54436400+vkadlcik@users.noreply.github.com>
|
@vkadlcik You can an early commit that has no sign-off. Can you fix this so DCO passes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advice against running "generate" and "chat" in parallel
Make users aware of possible segfaults (#346).
Place the notice at the beginning of the respective section. Also move
the existing notice on how long "lab generate" takes next to it.