feat(pkg/xast): add ModifyCaller function
#4639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
commented
Apr 18, 2025
Pantani
reviewed
Apr 22, 2025
Pantani
approved these changes
Apr 22, 2025
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
* feat(pkg/xast): add `ModifyCaller` function * update modify caller * lint * feedback Co-authored-by: Danilo Pantani <danpantani@gmail.com> --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> (cherry picked from commit 121c3a8) # Conflicts: # ignite/internal/plugin/testdata/execute_fail/go.mod # ignite/internal/plugin/testdata/execute_ok/go.mod # ignite/pkg/xast/function.go
julienrbrt
added a commit
that referenced
this pull request
Apr 22, 2025
* feat(pkg/xast): add `ModifyCaller` function (#4639) * feat(pkg/xast): add `ModifyCaller` function * update modify caller * lint * feedback Co-authored-by: Danilo Pantani <danpantani@gmail.com> --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> (cherry picked from commit 121c3a8) # Conflicts: # ignite/internal/plugin/testdata/execute_fail/go.mod # ignite/internal/plugin/testdata/execute_ok/go.mod # ignite/pkg/xast/function.go * conflicts * cl * up --------- Co-authored-by: julienrbrt <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
xast.ModifyCallerto swap arguments from a function.This is be required for improving the rollkit app (ignite/apps#192) instead of doing search and replaces.