Skip to content

feat(pkg/xast): add ModifyCaller function (backport #4639) #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

feat(pkg/xast): add ModifyCaller function (backport #4639) #4640

merged 4 commits into from
Apr 22, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2025

Add xast.ModifyCaller to swap arguments from a function.
This is be required for improving the rollkit app (ignite/apps#192) instead of doing search and replaces.

This is an automatic backport of pull request #4639 done by Mergify.

@julienrbrt @mergify
feat(pkg/xast): add ModifyCaller function (#4639)
853fbd1 
* feat(pkg/xast): add `ModifyCaller` function

* update modify caller

* lint

* feedback

Co-authored-by: Danilo Pantani <danpantani@gmail.com>

---------

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
(cherry picked from commit 121c3a8)

# Conflicts:
#	ignite/internal/plugin/testdata/execute_fail/go.mod
#	ignite/internal/plugin/testdata/execute_ok/go.mod
#	ignite/pkg/xast/function.go
@mergify mergify bot added the conflicts label Apr 22, 2025
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 22, 2025

Cherry-pick of 121c3a8 has failed:

On branch mergify/bp/release/v28.x.y/pr-4639
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 121c3a88.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/pkg/xast/function_test.go
	modified:   ignite/pkg/xast/xast.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/internal/plugin/testdata/execute_fail/go.mod
	both modified:   ignite/internal/plugin/testdata/execute_ok/go.mod
	both modified:   ignite/pkg/xast/function.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@julienrbrt julienrbrt self-assigned this Apr 22, 2025
@julienrbrt julienrbrt merged commit edd86f8 into release/v28.x.y Apr 22, 2025
39 of 42 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4639 branch April 22, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julienrbrt