feat: adjust liaison statement to/from group choices based on role #8883
Conversation
Need to confirm what is actually needed, but without these users may be able to create/edit LS's they can't actually fill in.
|
Actually not sure we need a separate IAB Executive Director. The IAB Executive Director is a member of the Secretariat, so the role should be sufficient. This is also related to this discussion: ietf-tools/liaison-tooling-2025a#7 Also I think we actually want to get rid of the Authorized Individual but we need to fully double-check that we don't use it anymore but that's the outcome of ietf-tools/liaison-tooling-2025a#25 and ietf-tools/liaison-tooling-2025a#11 I think I asked that Robert at some point and he might have looked into this already but I can find it right now: Is there a list of all currently Authorized Individuals somewhere, so we could quickly review it? |
|
Ok - I won't worry about the permissions for those roles then (i.e., I'll leave them as they are in this PR).
The easiest way to see these is through the Django admin in the sandbox. I can give you instructions for that offline. There are 137 Authorized Individuals for SDO groups. |
|
This addresses the from form issue for the people who currently have access - lets at least get this into a feature branch now, and add modeling liaison coordinators with a separate PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/liaisons #8883 +/- ##
================================================
Coverage ? 88.81%
================================================
Files ? 314
Lines ? 41441
Branches ? 0
================================================
Hits ? 36807
Misses ? 4634
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This refactors some internals of the liaison statement (LS) forms to improve testability and clarity. Adjusts the options available for "To" and "From" groups based on the user's role(s).
Note that these changes only impact the groups that can be used to populate the "From > Groups" and "To > Groups" fields. The "From > From contact", "From > Response Contacts", and "To > Contacts" fields and their behavior are unchanged. Furthermore, the "From" header field on the actual email that delivers the LS is not affected by this.
In the following, "any group" means IETF, IESG, IAB, any active area, or any active WG.
Roles permitted to add new outgoing LS:
Roles permitted to add new incoming LS (these were not changed):
Still a WIP to confirm the changes are in the right direction and for some further code cleanup.
Related to ietf-tools/liaison-tooling-2025a#4 and #4514