-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Sidebranch: fix console help link #30670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * change log for pull request #30167 * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * Delete changelog/29013.txt * Create 29013.txt * fix changelog name to align to the PR ID * remove trailing cr (fix linting error) --------- Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
CI Results: |
Build Results: |
drivera258
approved these changes
May 19, 2025
6 tasks
erentantekin
pushed a commit
that referenced
this pull request
May 23, 2025
* formatting * Fix broken link in the Web REPL help commands (#30167) * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * change log for pull request #30167 * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * Delete changelog/29013.txt * Create 29013.txt * fix changelog name to align to the PR ID * remove trailing cr (fix linting error) --------- Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com> * Update 30167.txt * Update log-help.hbs * Update log-help.hbs * try this way * fix changelog --------- Co-authored-by: Laurent Douillet <69690045+ldouillet@users.noreply.github.com> Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a sidebranch to merge in community pr that needs a formatting change before it can be merged.
Original PR #30167
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.