Skip to content

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented May 19, 2025

Description

Creating a sidebranch to merge in community pr that needs a formatting change before it can be merged.
Original PR #30167

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@Monkeychip Monkeychip added the ui label May 19, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 19, 2025
@Monkeychip Monkeychip modified the milestones: 1.20.0-rc, 1.19.5 May 19, 2025
* fix broken link in the Web REPL Commands help

change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to  https://developer.hashicorp.com/vault/docs/ui/web-cli

* Create changelog for #29013

* change log for pull request #30167

* fix broken link in the Web REPL Commands help

change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to  https://developer.hashicorp.com/vault/docs/ui/web-cli

* Create changelog for #29013

* Delete changelog/29013.txt

* Create 29013.txt

* fix changelog name to align to the PR ID

* remove trailing cr (fix linting error)

---------

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Copy link

github-actions bot commented May 19, 2025

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip changed the title Sidebranch prep Sidebranch: fix console help link May 19, 2025
@Monkeychip Monkeychip marked this pull request as ready for review May 19, 2025 15:00
@Monkeychip Monkeychip requested review from a team as code owners May 19, 2025 15:00
@Monkeychip Monkeychip requested a review from charlesn-hc May 19, 2025 15:00
Copy link

Build Results:
All builds succeeded! ✅

@Monkeychip Monkeychip enabled auto-merge (squash) May 19, 2025 16:46
@Monkeychip Monkeychip merged commit 3c79b95 into main May 19, 2025
33 checks passed
@Monkeychip Monkeychip deleted the ui/VAULT-35724/broken-link branch May 19, 2025 17:04
erentantekin pushed a commit that referenced this pull request May 23, 2025
* formatting

* Fix broken link in the Web REPL help commands (#30167)

* fix broken link in the Web REPL Commands help

change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to  https://developer.hashicorp.com/vault/docs/ui/web-cli

* Create changelog for #29013

* change log for pull request #30167

* fix broken link in the Web REPL Commands help

change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to  https://developer.hashicorp.com/vault/docs/ui/web-cli

* Create changelog for #29013

* Delete changelog/29013.txt

* Create 29013.txt

* fix changelog name to align to the PR ID

* remove trailing cr (fix linting error)

---------

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>

* Update 30167.txt

* Update log-help.hbs

* Update log-help.hbs

* try this way

* fix changelog

---------

Co-authored-by: Laurent Douillet <69690045+ldouillet@users.noreply.github.com>
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants