Fix broken link in the Web REPL help commands #30167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -25,6 +25,6 @@ Web REPL Commands: | |||
|
|
|||
| </pre> | |||
| <p class="console-ui-panel-intro is-font-mono has-bottom-margin-s"> | |||
| For more detailed documentation, see the <Hds::Link::Inline @href={{doc-link "/vault/docs/commands/web"}}>HashiCorp Developer site</Hds::Link::Inline>. | |||
There was a problem hiding this comment.
Thanks for fixing! I was wondering why the redirect was working appropriately here and noticed there that command is singular and here it's plural
hellobontempo
requested changes
Apr 6, 2025
hellobontempo
previously approved these changes
Apr 7, 2025
hellobontempo
approved these changes
Apr 15, 2025
|
It looks like there's a linting error so tests haven't run - are you able to resolve on your end? |
@ldouillet would love to get this in before the next patch release. Are you able to address the linting error mentioned above? |
|
I'm going to merge this into a sidebranch so I can update the formatting issues. |
570b2cb
into
hashicorp:ui/VAULT-35724/broken-link
1 of 2 checks passed
6 tasks
Monkeychip
added a commit
that referenced
this pull request
May 19, 2025
* formatting * Fix broken link in the Web REPL help commands (#30167) * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * change log for pull request #30167 * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * Delete changelog/29013.txt * Create 29013.txt * fix changelog name to align to the PR ID * remove trailing cr (fix linting error) --------- Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com> * Update 30167.txt * Update log-help.hbs * Update log-help.hbs * try this way * fix changelog --------- Co-authored-by: Laurent Douillet <69690045+ldouillet@users.noreply.github.com> Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
6 tasks
erentantekin
pushed a commit
that referenced
this pull request
May 23, 2025
* formatting * Fix broken link in the Web REPL help commands (#30167) * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * change log for pull request #30167 * fix broken link in the Web REPL Commands help change from https://developer.hashicorp.com/vault/docs/commands/web (broken) to https://developer.hashicorp.com/vault/docs/ui/web-cli * Create changelog for #29013 * Delete changelog/29013.txt * Create 29013.txt * fix changelog name to align to the PR ID * remove trailing cr (fix linting error) --------- Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com> * Update 30167.txt * Update log-help.hbs * Update log-help.hbs * try this way * fix changelog --------- Co-authored-by: Laurent Douillet <69690045+ldouillet@users.noreply.github.com> Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a broken link in the Web REPL help commands which is pointing to https://developer.hashicorp.com/vault/docs/commands/web (broken)
Changed to https://developer.hashicorp.com/vault/docs/ui/web-cli