Revert partial test changes for skipping FIPS tests for unsupported SHA3 hashes #30598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
|
Build Results: |
sgmiller
approved these changes
May 13, 2025
6 tasks
brewgator
pushed a commit
that referenced
this pull request
May 13, 2025
brewgator
pushed a commit
that referenced
this pull request
May 13, 2025
|
Backport to 1.19.x was done within: #30582 |
brewgator
added a commit
that referenced
this pull request
May 13, 2025
* no-op commit due to failed cherry-picking * Upgrade FIPS 1402 -> 1403 (#30576) * Upgrade FIPS 1402 -> 1403 * Clean up * changelog * Revert partial test changes for skipping FIPS tests for unsupported SHA3 hashes (#30598) --------- Co-authored-by: temp <temp@hashicorp.com> Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com> Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
drivera258
pushed a commit
that referenced
this pull request
May 14, 2025
drivera258
pushed a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert a partial fix/change had been implemented way back when we were originally looking at the 1.24 update and I missed reverting the change back then and it made it into #30576
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.