Skip to content

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #30576 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@brewgator
This person should resolve the merge-conflict(s) by either:

  • Manually completing the cherry picks into this branch
  • Creating a new branch and manually cherry-picking all commits being backported

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 12, 2025
Copy link

hashicorp-cla-app bot commented May 12, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented May 12, 2025

CI Results:
All Go tests succeeded! ✅

@brewgator brewgator marked this pull request as ready for review May 13, 2025 19:35
Copy link

github-actions bot commented May 13, 2025

Build Results:
All builds succeeded! ✅

@brewgator brewgator requested review from a team as code owners May 13, 2025 19:40
@brewgator brewgator requested a review from elliesterner May 13, 2025 19:40
@brewgator brewgator force-pushed the backport/fips-to-140_3/optionally-amused-muskrat branch from 8668baa to 1f5cae4 Compare May 13, 2025 19:41
@brewgator brewgator enabled auto-merge (squash) May 13, 2025 19:59
@brewgator brewgator merged commit 8eb9e9b into release/1.19.x May 13, 2025
91 of 92 checks passed
@brewgator brewgator deleted the backport/fips-to-140_3/optionally-amused-muskrat branch May 13, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants