Skip to content

Replace e.keyCode with e.key #30493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 5, 2025
Merged

Replace e.keyCode with e.key #30493

merged 6 commits into from
May 5, 2025

Conversation

jaireddjawed
Copy link
Contributor

Description

What does this PR do?

Modern browsers are deprecating the use of event.keyCode in favor of the more standardized event.key. This PR updates all instances of event.keyCode to use event.key instead.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@jaireddjawed jaireddjawed self-assigned this May 2, 2025
@jaireddjawed jaireddjawed requested a review from a team as a code owner May 2, 2025 04:37
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

Build Results:
All builds succeeded! ✅

@jaireddjawed jaireddjawed requested a review from a team as a code owner May 2, 2025 04:48
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

beagins
beagins reviewed May 2, 2025
View reviewed changes
@jaireddjawed jaireddjawed added this to the 1.20.0-rc milestone May 2, 2025
@jaireddjawed jaireddjawed added the ui label May 2, 2025
@jaireddjawed jaireddjawed requested a review from beagins May 2, 2025 19:39
beagins
beagins approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@beagins beagins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🎉 thank you for tackling this!!

ui/lib/core/addon/utils/keys.js
// a map of keyCode for use in keyboard event handlers
export default {
ENTER: 'Enter',
// some older browsers use 'Esc' instead of 'Escape'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! 👍

@jaireddjawed jaireddjawed merged commit 1150bc2 into main May 5, 2025
33 checks passed
@jaireddjawed jaireddjawed deleted the VAULT-35677-replace-keyCode-with-key branch May 5, 2025 17:06
Closed
6 tasks
drivera258 pushed a commit that referenced this pull request May 6, 2025
@jaireddjawed @drivera258
Replace e.keyCode with e.key (#30493)
d960675 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes
drivera258 pushed a commit that referenced this pull request May 6, 2025
@jaireddjawed @drivera258
Replace e.keyCode with e.key (#30493)
40db6c4 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes
beagins pushed a commit that referenced this pull request May 7, 2025
@jaireddjawed @beagins
Replace e.keyCode with e.key (#30493)
5eaa5d0 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes
@beagins beagins mentioned this pull request May 7, 2025
Merged
beagins pushed a commit that referenced this pull request May 8, 2025
@jaireddjawed @beagins
Replace e.keyCode with e.key (#30493)
7f95d4d 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes
beagins added a commit that referenced this pull request May 8, 2025
@beagins @jaireddjawed
Replace e.keyCode with e.key (#30493) (#30550)
d6611bd 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes

Co-authored-by: Jaired Jawed <jaired.jawed@hashicorp.com>
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
@jaireddjawed
Replace e.keyCode with e.key (hashicorp#30493)
b9b0dc0 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beagins beagins beagins approved these changes

@fairclothjm fairclothjm Awaiting requested review from fairclothjm

Assignees

@jaireddjawed jaireddjawed

Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.20.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@jaireddjawed @beagins