Skip to content

Backport 1.19.x: Replace e.keyCode with e.key #30550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Backport 1.19.x: Replace e.keyCode with e.key #30550

merged 1 commit into from
May 8, 2025

Conversation

beagins
Copy link
Contributor

@beagins beagins commented May 7, 2025 •
edited
Loading

Description

What does this PR do?

  • Manual Backport: Replace e.keyCode with e.key (Replace e.keyCode with e.key #30493)
  • Enterprise tests pass ✅

    235 tests completed in 183168 milliseconds, with 0 failed, 10 skipped, and 0 todo.
    1429 assertions of 1429 passed, 0 failed.

@jaireddjawed @beagins
Replace e.keyCode with e.key (#30493)
5eaa5d0 
* remove e.keyCode in favor of e.key

* remove key-codes.js

* add changelog

* update to satisfy pr comments

* changes

* changes
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 7, 2025
@beagins beagins added ui backport and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels May 7, 2025
@beagins beagins added this to the 1.19.4 milestone May 7, 2025
@beagins beagins marked this pull request as ready for review May 8, 2025 00:15
@beagins beagins requested review from a team as code owners May 8, 2025 00:15
@beagins beagins requested a review from erentantekin May 8, 2025 00:15
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025

Build Results:
All builds succeeded! ✅

@beagins beagins added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 8, 2025
@beagins beagins merged commit d6611bd into release/1.19.x May 8, 2025
57 of 63 checks passed
@beagins beagins deleted the backport-pr-30493-1.19.x branch May 8, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivera258 drivera258 drivera258 approved these changes

@erentantekin erentantekin Awaiting requested review from erentantekin erentantekin is a code owner automatically assigned from hashicorp/vault

Assignees
No one assigned
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
3 participants
@beagins @drivera258 @jaireddjawed