Fix type error in VectorizeLoops #8055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steven-johnson This fixes a bug in #8039, so if we backport that to release 17, we should backport this too. |
steven-johnson
approved these changes
Feb 1, 2024
steven-johnson
pushed a commit
that referenced
this pull request
Feb 1, 2024
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bounds_of_lanes is supposed to return scalars, but the Ramp visitor was constructing a broadcast vector constant for the index of the last lane, which was then vectorizing everything else.
Fixes #8054
If we get another fuzzer-found failure coming from the bilateral grid app I'll do some refactoring in the fuzz_schedule test to not have to repeat the whole algorithm.