[Bugfix] Fix search by trace:id with short trace ID #5331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cebcd1 to
0a419f3
Compare
| }) | ||
|
|
||
| t.Run(fmt.Sprintf("%s: include span id", v.Version()), func(t *testing.T) { | ||
| spanID := "0000000000010203" |
There was a problem hiding this comment.
Do we need to support search with trimmed leading zeros, e.g. {span:id = "10203"} ?
There was a problem hiding this comment.
Added fix in a separate PR: #5343
a4a7a1a to
2c3a94a
Compare
3 tasks
3 tasks
2c3a94a to
7f81273
Compare
7f81273 to
32858f9
Compare
|
+ rebase from latest main to resolve conflicts |
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Jul 18, 2025
* search tests refactoring * search tests refactoring * search test refactoring: trace id input param * Tests for search by trace:id and span:id * [bugfix] Correct filtration by trace:id * make gen-parquet-query * Minor optimisation * [bugfix] fix regression bug for search by link:spanID * Search tests: find all traces case * Mute gosec linter for tests * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Trace IDs are stored with leading zeros, no need to trim
{trace_id!="abc"}.link:spanID. The bug was hidden because withbytes.TrimLeft(id, "\x00")results afterHexStringToTraceIDandHexStringToSpanIDwere the sameWhich issue(s) this PR fixes:
Fixes #4437 and #4967
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]