Proposal: query span id with no leading zeros #5343
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslan-mikhailov
commented
Jul 1, 2025
pkg/traceql/ast_conditions.go
Outdated
| operand := o.RHS.(Static) | ||
| if o.LHS.(Attribute).Intrinsic == IntrinsicSpanID { | ||
| operand = normalizeSpanIDOperand(operand) | ||
| o.RHS = operand // Update the operation with the normalized operand |
There was a problem hiding this comment.
I'm not sure whether it's the right way to do to change LHS/RHS inside extractConditions
0b7fe7d to
ea4ecae
Compare
3 tasks
ea4ecae to
6a71b19
Compare
6a71b19 to
b8e4031
Compare
| { | ||
| Op: "Equal", | ||
| CompareCond: `bytes.Equal(bytes.TrimLeft(vv, "\x00"), p.value)`, | ||
| RangeCond: "", |
There was a problem hiding this comment.
I don't really like that we have to skip RangeCond. Maybe it would be better to add/remove leading zeroes on write as we do for trace id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes search by span id without leading zeros
Contains #5331. Diff is in the last 3 commits
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]