Skip to content

Shift e2e tests to project root #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

mridulji
Copy link
Contributor

@mridulji mridulji commented Aug 8, 2022

What this PR does / Why we need it: This PR separates the testing folder from other important implementations of open-match core and shifts it to project root location.

Which issue(s) this PR fixes:

Closes #1448
Closes #1302

Special notes for your reviewer:

@mridulji mridulji changed the title shifted e2e tests to project root Shift e2e tests to project root Aug 8, 2022
@mridulji mridulji force-pushed the separate_testing_package branch from 50097fb to 5be6bac Compare August 12, 2022 16:02
@mridulji mridulji force-pushed the separate_testing_package branch from 5be6bac to bdba5bd Compare September 7, 2022 10:45
@mridulji mridulji marked this pull request as draft November 22, 2022 11:41
@mridulji mridulji force-pushed the separate_testing_package branch from bdba5bd to df288b4 Compare November 24, 2022 14:09
@mridulji mridulji force-pushed the separate_testing_package branch from df288b4 to 426a14e Compare November 24, 2022 14:10
@mridulji mridulji marked this pull request as ready for review November 24, 2022 14:11
@mridulji mridulji added this to the v1.6.0 milestone Dec 5, 2022
@mridulji mridulji added area/developer-experience This issue impacts developer experience when building a Matchmaker using Open Match area/testing enhancement New feature or request labels Dec 5, 2022
Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntxerror syntxerror merged commit 927a976 into googleforgames:main Dec 5, 2022
syntxerror added a commit that referenced this pull request Dec 6, 2022
* Default values of configs (#1508)

* setting validation and default values of configs

* config check in internal/config package

* Add open-match-override setting (#1490)

* Add open-match-override setting

* Added enabled

Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com>
Co-authored-by: Mridul Goswami <mridulgoswami@google.com>

* shifted e2e tests to project root (#1481)

* release 1.6.0-rc.1 changes

* release changes for tutorials

* remaining changes

Co-authored-by: kemurayama <7068107+kemurayama@users.noreply.github.com>
Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/developer-experience This issue impacts developer experience when building a Matchmaker using Open Match area/testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies for e2e tests by creating independent go mod files. Making e2e testing packages public
2 participants