Skip to content

Conversation

mridulji
Copy link
Contributor

What this PR does / Why we need it: This PR makes changes required for release v1.6.0-rc.1.

Which issue(s) this PR fixes:

Closes #1509

Special notes for your reviewer:

mridulji and others added 5 commits December 2, 2022 12:10
* setting validation and default values of configs

* config check in internal/config package
* Add open-match-override setting

* Added enabled

Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com>
Co-authored-by: Mridul Goswami <mridulgoswami@google.com>
# Controls if users need to install open-match-override ConfigMap.
open-match-override:
enabled: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is actually for L299. The version should be updated there as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing 👍🏻

Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntxerror syntxerror merged commit 4b8761a into googleforgames:release-1.6 Dec 6, 2022
@mridulji mridulji added this to the v1.6.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants