Fix String with escapes prefix matching on Erlang. #3139
Conversation
There was a problem hiding this comment.
Hello! Thank you for this
Could you reuse the code here please? I would like to avoid having two different bits of code for this 🙏
gleam/compiler-core/src/javascript/pattern.rs
Line 856 in 2c59b9c
It'll need to be make slightly more flexible to specify whether it's utf8 (Erlang) or utf16 (JavaScript)
3ee5afd to
4ba43ae
Compare
Fixes gleam-lang#3126. Fixes String prefix matching on Erlang when the prefix contains escape characters or unicode codepoints by ensuring the correct prefix byte length is matched against. Signed-off-by: Nashwan Azhari <aznashwan@icloud.com>
4ba43ae to
beea7b5
Compare
Done, hadn't noticed it before since I only investigated the Erlang part of the compiler tree but it was basically exactly what I needed. I've adapted the function to directly return the updated string, properly treat the escape chars Gleam supports, and moved it to a top-level I've also split the specific prefixes tested against to make the transpiled code a little easier to follow. |
Adapt gleam-lang/gleam#3139 to the Nix target
Adapt gleam-lang/gleam#3139 to the Nix target
* fix module select in guard clauses adapt gleam-lang/gleam#3045 to the Nix target * use common string escape chars function Adapt gleam-lang/gleam#3139 to the Nix target * add 'module_access_aliased' test to nix
Fixes #3126.
Fixes String prefix matching on Erlang when the prefix contains escape characters or unicode codepoints by ensuring the correct prefix byte length is matched against.