Skip to content

Conversation

Acepie
Copy link
Contributor

@Acepie Acepie commented Apr 26, 2024

Closes #3043

looks like we only had tests where alias == name so added a couple new tests and fixed the typo

@Acepie Acepie force-pushed the fixModuleSelectGuard branch from 0957e47 to da531f3 Compare April 26, 2024 17:35
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you're fast! I was just about to try and fix this myself! Thank you

@lpil lpil enabled auto-merge (rebase) April 26, 2024 17:38
@lpil lpil disabled auto-merge April 26, 2024 17:43
@lpil lpil merged commit ebf374e into gleam-lang:main Apr 26, 2024
@Acepie Acepie deleted the fixModuleSelectGuard branch April 26, 2024 18:06
PgBiel added a commit to Glistix/glistix that referenced this pull request May 26, 2024
PgBiel added a commit to Glistix/glistix that referenced this pull request Jun 8, 2024
PgBiel added a commit to Glistix/glistix that referenced this pull request Jun 8, 2024
PgBiel added a commit to Glistix/glistix that referenced this pull request Jun 8, 2024
* fix module select in guard clauses

adapt gleam-lang/gleam#3045 to the Nix target

* use common string escape chars function

Adapt gleam-lang/gleam#3139 to the Nix target

* add 'module_access_aliased' test to nix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case guard statement using constant from other module generates invalid JS code
2 participants