Skip to content

.net9 #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

.net9 #12064

merged 1 commit into from
Feb 20, 2025

Conversation

gerhardol
Copy link
Member

@gerhardol gerhardol commented Nov 24, 2024 •
edited
Loading

Requires #12167 (due to submodule changes)
Requires submodules first like gitextensions/ICSharpCode.TextEditor#48

Proposed changes

An attempt to try out .net9
There are the usual performance and syntax improvements in .net9/c#13
.net9 do not have long term support, update to .net10 will be required in a year.

One specific feature that is interesting is dark mode, discussions in #9191 and more issues

Test methodology

?

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

RussKie
RussKie reviewed Nov 24, 2024
View reviewed changes
mstv
mstv reviewed Nov 25, 2024
View reviewed changes
@gerhardol
Copy link
Member Author

Appveyor has still no (mainline) branch so build fails
VSTHRD103,WFO1000 for .net9 is now suppressed, so no dependencies and fewer changes
There should be at least a 5.2 release before this PR is merged - if we want this at all and not wait for LTS .net10

@gerhardol gerhardol mentioned this pull request Dec 22, 2024
Merged
@mstv
Copy link
Member

mstv commented Jan 4, 2025

🎉 AppVeyor builds it! 🚀

Sorry for cancelling the first build which could succeed.

@gerhardol gerhardol changed the title WIP .net9 .net9 Jan 4, 2025
@gerhardol
Copy link
Member Author

AppVeyor has now added support for .net9, so this is n longer blocked.
Will change this from draft when we have decided what to do with a 5.2 release.
(Then .net9 is to be decided on.)

mstv
mstv approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@mstv mstv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have shortly run only once

@gerhardol gerhardol marked this pull request as ready for review February 3, 2025 22:25
@gerhardol
Copy link
Member Author

I would like to see #12149 and some follow ups to that before merging this, there are also submodule changes.
VSTHRD103,WFO1000 are suppressed, may be handled in 9.0.3 (March?) but can be handled later.
But from draft to get agreement to merge.

@gerhardol gerhardol force-pushed the feature/net9 branch 2 times, most recently from 0d8d97e to 65fad69 Compare February 17, 2025 22:24
@gerhardol gerhardol mentioned this pull request Feb 17, 2025
Merged
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Feb 18, 2025
@gerhardol
feat!: .net9
0e6acfb 
suppress VSTHRD103,WFO1000

Refs: gitextensions#12064
mstv
mstv approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo yet uncommitted comment

@vbjay
Copy link
Contributor

vbjay commented Feb 19, 2025 •
edited
Loading

https://github.com/gitextensions/gitextensions/blob/master/eng%2FUpdate-DotnetVersion.ps1. Need to update ha. GitHub nobile was weird. I see the modification. Nevermind.

@mstv mstv mentioned this pull request Feb 20, 2025
Merged
@gerhardol
feat!: .net9
6119621 
suppress VSTHRD103,WFO1000

Refs: gitextensions#12064
@mstv mstv added this to the v5.3 milestone Feb 20, 2025
@gerhardol gerhardol merged commit 03e078e into gitextensions:master Feb 20, 2025
4 checks passed
@gerhardol gerhardol deleted the feature/net9 branch February 20, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmiossec pmiossec pmiossec approved these changes

@RussKie RussKie RussKie approved these changes

@mstv mstv mstv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gerhardol @mstv @vbjay @pmiossec @RussKie