Skip to content

Conversation

gerhardol
Copy link
Member

@gerhardol gerhardol commented Jan 26, 2025

Proposed changes

The default appearance is unchanged, only seen in the added theme.
The primary reason for this PR is though to allow adjustments for dark mode.
Review commit by commit is preferred, some of the changes are related.

  • cleanup unused theme color Graph
    Note: bright theme could probably be removed, changes are not noticeable

  • themeable editor and linenumber
    Updated ICSharp interface to allow themeing from Git Extensions

  • style: Themeable panel backgrounds

Themeable background panels (including grid view) in the main interface.
The GitExtensionsDialog are updated too but not the old style
GitExtensionsForm.
The default visual appearance is unchanged.

  • add Light+ theme

Slightly darker panel backgrounds and a visible linenumber panel
This is inspired by the VS Code theme Light+
The panels in the main interface and some (newer style) forms
are set to be slightly darker, to minimize the extremely white GE interface.
The editor background is unchanged as in VS Code.

Screenshots

Before

default, unchanged
image

After

image

console output
An alternative is to use SystemColors.Control, also OK in dark mode
image

Test methodology

Visual

Merge strategy

  • Rebase merge (PR submitter must change the commit message for the last commit).

✒️ I contribute this code under The Developer Certificate of Origin.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerhardol gerhardol force-pushed the feature/light-plus-theme branch from 6430e97 to 71773aa Compare January 31, 2025 22:11
@gerhardol
Copy link
Member Author

gerhardol commented Feb 9, 2025

no change for invariant/dark theme

  • Removed bright theme
  • A few more panels should be themed for light+ (and upcoming dark+)
  • When dimming colors, this must be one to the background and for light+/dark+ this is not exactly the same as SystemColors.Window (but not a big difference)
    Note: A similar change may be needed for AdaptColor(), but it is not that simple, may be a followup PR.

I would like to merge this after the FileStatusList changes are merged,

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. I have not noticed any side-effect to the default theme.
As for me, a rebase and squash would be good.

@gerhardol gerhardol force-pushed the feature/light-plus-theme branch from 2d72440 to 858bf95 Compare February 14, 2025 22:50
cleanup unchanged colors in bright theme
Prepare for ICSharp update where colors can be themed from
GitExtensions, including controlling if a color should not be adapted to
the theme.
Themeable background panels (including grid view) in the main interface.
The GitExtensionsDialog are updated too but not the old style
GitExtensionsForm.
The default visual appearance is unchanged.
Slightly darker panel backgrounds and a visible linenumber panel
Very few changes, superseded by light+ theme.

Refs: gitextensions#12167
@gerhardol gerhardol force-pushed the feature/light-plus-theme branch from 858bf95 to 21a9f9a Compare February 18, 2025 20:48
@gerhardol gerhardol merged commit 3880c0f into gitextensions:master Feb 18, 2025
3 of 4 checks passed
@gerhardol gerhardol deleted the feature/light-plus-theme branch February 18, 2025 21:02
@mstv mstv added this to the v5.3 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants