-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add Light+ theme #12167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Light+ theme #12167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6430e97
to
71773aa
Compare
no change for invariant/dark theme
I would like to merge this after the FileStatusList changes are merged, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible. I have not noticed any side-effect to the default theme.
As for me, a rebase and squash would be good.
2d72440
to
858bf95
Compare
cleanup unchanged colors in bright theme
Prepare for ICSharp update where colors can be themed from GitExtensions, including controlling if a color should not be adapted to the theme.
Themeable background panels (including grid view) in the main interface. The GitExtensionsDialog are updated too but not the old style GitExtensionsForm. The default visual appearance is unchanged.
Slightly darker panel backgrounds and a visible linenumber panel
Very few changes, superseded by light+ theme. Refs: gitextensions#12167
858bf95
to
21a9f9a
Compare
Proposed changes
The default appearance is unchanged, only seen in the added theme.
The primary reason for this PR is though to allow adjustments for dark mode.
Review commit by commit is preferred, some of the changes are related.
cleanup unused theme color Graph
Note: bright theme could probably be removed, changes are not noticeable
themeable editor and linenumber
Updated ICSharp interface to allow themeing from Git Extensions
style: Themeable panel backgrounds
Themeable background panels (including grid view) in the main interface.
The GitExtensionsDialog are updated too but not the old style
GitExtensionsForm.
The default visual appearance is unchanged.
Slightly darker panel backgrounds and a visible linenumber panel
This is inspired by the VS Code theme Light+
The panels in the main interface and some (newer style) forms
are set to be slightly darker, to minimize the extremely white GE interface.
The editor background is unchanged as in VS Code.
Screenshots
Before
default, unchanged

After
console outputAn alternative is to use SystemColors.Control, also OK in dark modeTest methodology
Visual
Merge strategy
✒️ I contribute this code under The Developer Certificate of Origin.