fix(wallet): Retry balance refresh on tax errors #3907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jul 3, 2025
groyoh
reviewed
Jul 3, 2025
d60b594 to
b80a8ef
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Description This PR adds auto-retry logic for the `Wallets::RefreshOngoingBalanceJob` for two errors happening with anrock integration: - `Net::ReadTimeout` - `Integrations::Aggregator::BadGatewayError` The new `Integrations::Aggregator::BadGatewayError` directly inherit from `LagoHttpClient::HttpError` to make sure we are not breaking logic already in place around this error type (#3234 for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds auto-retry logic for the
Wallets::RefreshOngoingBalanceJobfor two errors happening with anrock integration:Net::ReadTimeoutIntegrations::Aggregator::BadGatewayErrorThe new
Integrations::Aggregator::BadGatewayErrordirectly inherit fromLagoHttpClient::HttpErrorto make sure we are not breaking logic already in place around this error type (#3234 for example)