fix(integration): Fix error handling for Bad Gateway errors received as HTTP 200 #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
approved these changes
Feb 21, 2025
03fc635 to
901f383
Compare
rsempe
approved these changes
Feb 21, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jul 3, 2025
## Description This PR adds auto-retry logic for the `Wallets::RefreshOngoingBalanceJob` for two errors happening with anrock integration: - `Net::ReadTimeout` - `Integrations::Aggregator::BadGatewayError` The new `Integrations::Aggregator::BadGatewayError` directly inherit from `LagoHttpClient::HttpError` to make sure we are not breaking logic already in place around this error type (#3234 for example)
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Description This PR adds auto-retry logic for the `Wallets::RefreshOngoingBalanceJob` for two errors happening with anrock integration: - `Net::ReadTimeout` - `Integrations::Aggregator::BadGatewayError` The new `Integrations::Aggregator::BadGatewayError` directly inherit from `LagoHttpClient::HttpError` to make sure we are not breaking logic already in place around this error type (#3234 for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Sometime jobs to fetch taxes from Anrock are failing with a
JSON::ParseError. It happens because the server is responding with anHTTP 200even if the message contains the HTML markup for anHTTP 502 Bad Gateway...Description
This PR adds some logic to detect the presence of the error in the response body and re-reraise the right error for a correct handling, in this case an auto-retry of job