chore(api-key): Add pagination and ordering tests for API Keys GraphQL endpoint #3835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
approved these changes
Jun 16, 2025
We used the following query:
```ruby
current_organization.api_keys.order(created_at: :asc).page(page).limit(limit)
```
which resulted in the following SQL:
```sql
SELECT "api_keys"."id",
"api_keys"."organization_id",
"api_keys"."value",
"api_keys"."created_at",
"api_keys"."updated_at",
"api_keys"."expires_at",
"api_keys"."last_used_at",
"api_keys"."name",
"api_keys"."permissions"
FROM "api_keys"
WHERE (
expires_at IS NULL
OR expires_at > '2025-06-16 12:41:11.750724'
)
AND "api_keys"."organization_id" = '...'
ORDER BY "api_keys"."created_at" ASC
LIMIT 5 OFFSET 25
```
This is due to Kaminari's way of handling pagination, which requires the `page` and `per` methods to be called in a specific order. `per` will then properly override the `limit` and `offset`. If `per` is not called, Kaminari will define the `OFFSET` using the `page` and default page size.
99537fc to
c72646b
Compare
vincent-pochet
approved these changes
Jun 16, 2025
floganz
reviewed
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR was originally created to fix the API Keys GraphQL resolver (See previous description below). But it was also fixed and merged in #3830. Since I added some tests, I rebased and kept the tests.
Description
This PR adds tests for ordering and paginating the API Key GraphQL endpoint.
Initial description below
Context
The pagination for the API Keys GraphQL resolver is not working properly.
Description
We used the following query:
which resulted in the following SQL:
This is due to Kaminari's way of handling pagination, which requires the
pageandpermethods to be called in a specific order.perwill then properly override thelimitandoffset. Ifperis not called, Kaminari will define theOFFSETusing thepageand default page size.