Revert "misc(invoice): Remove OpenStruct for taxes in pay in advance" #4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
approved these changes
Aug 27, 2025
vincent-pochet
added a commit
that referenced
this pull request
Aug 28, 2025
## Context This PR is a new approach to #4211 The goal here is to make sure that we will not accidentally persist a Invoice that was not supposed to be. ## Description Instead of relying on a `Invoice` model, it introduces a new `FakeInvoice` defined as a `Data` structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4189