Skip to content

misc(open-struct): Fake in advance invoices #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

misc(open-struct): Fake in advance invoices #4214

merged 1 commit into from
Aug 28, 2025

Conversation

vincent-pochet
Copy link
Collaborator

@vincent-pochet vincent-pochet commented Aug 28, 2025 •
edited
Loading

Context

This PR is a new approach to #4211

The goal here is to make sure that we will not accidentally persist a Invoice that was not supposed to be.

Description

Instead of relying on a Invoice model, it introduces a new FakeInvoice defined as a Data structure

@vincent-pochet vincent-pochet marked this pull request as ready for review August 28, 2025 09:04
groyoh
groyoh approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@groyoh groyoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would freeze on the invoice work instead or do we expect to modify some attributes ?

@vincent-pochet
Copy link
Collaborator Author

Would freeze on the invoice work instead or do we expect to modify some attributes ?

It could work, we are not not modifying anything. Still I prefer to use a dedicated structure, it could save some unexpected behavior.

@vincent-pochet vincent-pochet merged commit 66b3f41 into main Aug 28, 2025
21 of 22 checks passed
@vincent-pochet vincent-pochet deleted the misc-fake-invoice branch August 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groyoh groyoh groyoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @groyoh