Skip to content

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/kind enhancement
/platform aws

What this PR does / why we need it:
Data volumes are also excluded from the hash calculation for in-place updates similar to provider config.

Which issue(s) this PR fixes:
Part of gardener/gardener#10219

Special notes for your reviewer:
Follow-up of #1276

Release note:

NONE

@shafeeqes shafeeqes requested review from a team as code owners May 20, 2025 12:40
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 20, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2025
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 20, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@kon-angelo kon-angelo merged commit f02c392 into gardener:master May 20, 2025
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 20, 2025
kon-angelo added a commit that referenced this pull request May 20, 2025
…pdates (#1325)

* Exclude data volumes from hash if update strategy is in-place

* Update worker example

* add comments to func

---------

Co-authored-by: Konstantinos Angelopoulos <konstantinos.angelopoulos@sap.com>
@shafeeqes shafeeqes deleted the inplace-updates-worker branch May 21, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants