Skip to content

[GEP-31] Adapt extension to support in-place updates #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 20, 2025
Merged

[GEP-31] Adapt extension to support in-place updates #1276

merged 10 commits into from
May 20, 2025

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Apr 11, 2025 •
edited
Loading

How to categorize this PR?

/area control-plane delivery open-source scalability
/kind enhancement
/platform aws

What this PR does / why we need it:
This PR adapts the extension to support in-place updates.

  • The worker controller needs to set the appropriate update strategy in the machine deployment
  • The changes to worker providerConfig or relevant fields(which affect the worker pool hash calculation) should be denied.
  • The providerConfig is skipped from worker pool hash calculation.

Note

Changing these fields will cause a change in the calculation of the WorkerPool hash. Currently, machine-controller-manager does not provide an UpdateMachine call to update the data volumes or provider config in-place. gardener-node-agent cannot update the provider config in-place either. So we disallow changing these fields if the update strategy is in-place.

Which issue(s) this PR fixes:
Part of gardener/gardener#10219

Special notes for your reviewer:
/hold until gardener/gardener is released with required changes.
and machine-controller-manager-provider-aws image is available.

Release note:

This extension now supports in-place node updates. Read more about it [here](https://github.com/gardener/gardener/blob/master/docs/proposals/31-inplace-node-update.md).

@shafeeqes shafeeqes requested review from a team as code owners April 11, 2025 10:47
@gardener-robot gardener-robot added area/control-plane Control plane related area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels Apr 11, 2025
@shafeeqes shafeeqes marked this pull request as draft April 11, 2025 10:47
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 11, 2025
@shafeeqes shafeeqes mentioned this pull request Apr 11, 2025
Closed
40 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2025
@shafeeqes shafeeqes force-pushed the inplace-updates-worker branch from 2898f5a to 447218d Compare April 17, 2025 14:30
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 17, 2025
@shafeeqes shafeeqes changed the title Adapt extension to support InPlace updates [GEP-31] Adapt extension to support InPlace updates Apr 21, 2025
@shafeeqes shafeeqes force-pushed the inplace-updates-worker branch from 447218d to 2dc616e Compare April 22, 2025 09:20
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Apr 22, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 22, 2025
@shafeeqes shafeeqes force-pushed the inplace-updates-worker branch from 2dc616e to 2eb618c Compare April 22, 2025 09:47
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 22, 2025
@shafeeqes shafeeqes force-pushed the inplace-updates-worker branch from 2eb618c to 5fba4e4 Compare April 29, 2025 14:46
@shafeeqes shafeeqes force-pushed the inplace-updates-worker branch from a617a5c to 65ee47b Compare May 20, 2025 08:45
@gardener-robot gardener-robot added the needs/review Needs review label May 20, 2025
@shafeeqes shafeeqes requested a review from kon-angelo May 20, 2025 08:45
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
hebelsan
hebelsan previously approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels May 20, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) reviewed/lgtm Has approval for merging labels May 20, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@hebelsan hebelsan merged commit e72bab5 into gardener:master May 20, 2025
17 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 20, 2025
@shafeeqes shafeeqes deleted the inplace-updates-worker branch May 20, 2025 09:31
@shafeeqes shafeeqes mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

@kon-angelo kon-angelo Awaiting requested review from kon-angelo

Assignees

@acumino acumino

Labels
area/control-plane Control plane related area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else platform/aws Amazon web services platform/infrastructure size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shafeeqes @acumino @hebelsan @gardener-robot @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3