chore(ci): fix windows tests #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
previously approved these changes
Jan 16, 2023
vvagaytsev
previously approved these changes
Jan 16, 2023
|
I wonder if garden should install this command, but that would probably be complicated / out of scope as garden would need to parse the kubecontext. |
|
Closing as this does not, in fact, fix the windows tests. |
|
Reopening to be able to use circleci ssh later to investigate this further. |
stefreak
reviewed
Jan 16, 2023
vvagaytsev
pushed a commit
that referenced
this pull request
Jan 24, 2023
* chore(ci): fix windows tests * chore(ci): set CLOUDSDK_PYTHON env variable The google cloud auth changes https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke require a new plugin to be installed, and forgot to add it to our windows runners during #3431 Additionally, we apply the workaround described in https://stackoverflow.com/questions/57024587/why-the-gcloud-components-update-command-always-show-restarting-command/75137898#75137898 which sets an environment variable that makes gcloud install command work without additional terminal windows. See also https://stackoverflow.com/a/75137898/1518423 Co-authored-by: Steffen Neubauer <steffen@garden.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The google cloud auth changes https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke require a new plugin to be installed, and forgot to add it to our windows runners during #3431
Additionally, we apply this workaround which sets an environment variable that makes gcloud install command work without additional terminal windows.
Which issue(s) this PR fixes:
Fixes CI windows tests
Special notes for your reviewer:
I'm also adding the
--limit-outputoption tochococommands to reduce progress output spam in our CI logs.